From d61ce8cf6b5bda5a3bd0f99c5f65c9440d799a0f Mon Sep 17 00:00:00 2001 From: Ben Clifford Date: Wed, 30 Oct 2024 11:09:02 +0000 Subject: [PATCH] Fix filesystem radio type annotation: the wrong kind of Queue Prior to this PR, filesystem_receiver was annotated as taking queue.Queue. This was incorrect (but not detected or enforced by any tooling - because type annotations are not carried across the invoking Process constructor) The receiver actually takes a multiprocessing.Queue, which is used without a namespace, like the rest of this source file. --- parsl/monitoring/monitoring.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parsl/monitoring/monitoring.py b/parsl/monitoring/monitoring.py index c63b45611f..a1b20f2705 100644 --- a/parsl/monitoring/monitoring.py +++ b/parsl/monitoring/monitoring.py @@ -258,7 +258,7 @@ def close(self) -> None: @wrap_with_logs -def filesystem_receiver(logdir: str, q: "queue.Queue[TaggedMonitoringMessage]", run_dir: str) -> None: +def filesystem_receiver(logdir: str, q: Queue[TaggedMonitoringMessage], run_dir: str) -> None: logger = set_file_logger("{}/monitoring_filesystem_radio.log".format(logdir), name="monitoring_filesystem_radio", level=logging.INFO)