From 6ddcc5441d48056345ef1a1597d07d398455c41d Mon Sep 17 00:00:00 2001 From: Ben Clifford Date: Fri, 13 Oct 2023 11:56:20 +0000 Subject: [PATCH 1/3] add whitespace to try something with readthedocs --- docs/userguide/configuring.rst | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/userguide/configuring.rst b/docs/userguide/configuring.rst index 91685e275c..7e2223c9da 100644 --- a/docs/userguide/configuring.rst +++ b/docs/userguide/configuring.rst @@ -105,18 +105,18 @@ Stepping through the following question should help formulate a suitable configu 2. How many nodes will be used to execute the apps? What task durations are necessary to achieve good performance? -+--------------------------------------------+----------------------+-------------------------------------+ -| Executor | Number of Nodes [*]_ | Task duration for good performance | -+============================================+======================+=====================================+ -| `parsl.executors.ThreadPoolExecutor` | 1 (Only local) | Any | -+--------------------------------------------+----------------------+-------------------------------------+ -| `parsl.executors.HighThroughputExecutor` | <=2000 | Task duration(s)/#nodes >= 0.01 | -| | | longer tasks needed at higher scale | -+--------------------------------------------+----------------------+-------------------------------------+ -| `parsl.executors.WorkQueueExecutor` | <=1000 [*]_ | 10s+ | -+--------------------------------------------+----------------------+-------------------------------------+ -| `parsl.executors.taskvine.TaskVineExecutor`| <=1000 [*]_ | 10s+ | -+--------------------------------------------+----------------------+-------------------------------------+ ++---------------------------------------------+----------------------+-------------------------------------+ +| Executor | Number of Nodes [*]_ | Task duration for good performance | ++=============================================+======================+=====================================+ +| `parsl.executors.ThreadPoolExecutor` | 1 (Only local) | Any | ++---------------------------------------------+----------------------+-------------------------------------+ +| `parsl.executors.HighThroughputExecutor` | <=2000 | Task duration(s)/#nodes >= 0.01 | +| | | longer tasks needed at higher scale | ++---------------------------------------------+----------------------+-------------------------------------+ +| `parsl.executors.WorkQueueExecutor` | <=1000 [*]_ | 10s+ | ++---------------------------------------------+----------------------+-------------------------------------+ +| `parsl.executors.taskvine.TaskVineExecutor` | <=1000 [*]_ | 10s+ | ++---------------------------------------------+----------------------+-------------------------------------+ .. [*] Assuming 32 workers per node. If there are fewer workers launched From 30ac4ca4e996a22eb19c71b8943c57a8d167128d Mon Sep 17 00:00:00 2001 From: Ben Clifford Date: Fri, 13 Oct 2023 12:10:50 +0000 Subject: [PATCH 2/3] hack away ndcctools port --- parsl/executors/taskvine/manager_config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/parsl/executors/taskvine/manager_config.py b/parsl/executors/taskvine/manager_config.py index ee7c65a873..89ed20c911 100644 --- a/parsl/executors/taskvine/manager_config.py +++ b/parsl/executors/taskvine/manager_config.py @@ -2,7 +2,7 @@ from dataclasses import dataclass from typing import Optional -from ndcctools.taskvine.cvine import VINE_DEFAULT_PORT +# from ndcctools.taskvine.cvine import VINE_DEFAULT_PORT @dataclass @@ -142,7 +142,7 @@ class TaskVineManagerConfig: """ # Connection and communication settings - port: int = VINE_DEFAULT_PORT + port: int = 99999999 address: str = socket.gethostname() project_name: Optional[str] = None project_password_file: Optional[str] = None From fdb911391e0d66e75c817df6c222cda4a8dd8b54 Mon Sep 17 00:00:00 2001 From: Ben Clifford Date: Fri, 13 Oct 2023 12:24:27 +0000 Subject: [PATCH 3/3] hack away ndcctools port --- parsl/executors/taskvine/factory.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/parsl/executors/taskvine/factory.py b/parsl/executors/taskvine/factory.py index 24f74f3fe3..62313cd2af 100644 --- a/parsl/executors/taskvine/factory.py +++ b/parsl/executors/taskvine/factory.py @@ -3,8 +3,6 @@ from parsl.process_loggers import wrap_with_logs from parsl.executors.taskvine.errors import TaskVineFactoryFailure -from ndcctools.taskvine import Factory - logger = logging.getLogger(__name__)