From d7f083072d80e0a07a0f26f5ccfa6a15f51b5961 Mon Sep 17 00:00:00 2001
From: Ben Clifford <benc@hawaga.org.uk>
Date: Thu, 21 Sep 2023 10:02:55 +0100
Subject: [PATCH 1/2] Document parsl-perf (#2891)

---
 docs/userguide/index.rst      |  1 +
 docs/userguide/parsl_perf.rst | 53 +++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 docs/userguide/parsl_perf.rst

diff --git a/docs/userguide/index.rst b/docs/userguide/index.rst
index ae7df17450..21de9eb704 100644
--- a/docs/userguide/index.rst
+++ b/docs/userguide/index.rst
@@ -19,4 +19,5 @@ User guide
    joins
    usage_tracking
    plugins
+   parsl_perf
    performance
diff --git a/docs/userguide/parsl_perf.rst b/docs/userguide/parsl_perf.rst
new file mode 100644
index 0000000000..2ea1adb00f
--- /dev/null
+++ b/docs/userguide/parsl_perf.rst
@@ -0,0 +1,53 @@
+.. _label-parsl-perf:
+
+Measuring performance with parsl-perf
+=====================================
+
+``parsl-perf`` is tool for making basic performance measurements of Parsl
+configurations.
+
+It runs increasingly large numbers of no-op apps until a batch takes
+(by default) 120 seconds, giving a measurement of tasks per second.
+
+This can give a basic measurement of some of the overheads in task
+execution.
+
+``parsl-perf`` must be invoked with a configuration file, which is a Python
+file containing a variable ``config`` which contains a `Config` object, or
+a function ``fresh_config`` which returns a `Config` object. The
+``fresh_config`` format is the same as used with the pytest test suite.
+
+To specify a ``parsl_resource_specification`` for tasks, add a ``--resources``
+argument.
+
+To change the target runtime from the default of 120 seconds, add a
+``--time`` parameter.
+
+For example:
+
+.. code-block:: bash
+
+
+    $ python -m parsl.benchmark.perf --config parsl/tests/configs/workqueue_ex.py --resources '{"cores":1, "memory":0, "disk":0}'
+    ==== Iteration 1 ====
+    Will run 10 tasks to target 120 seconds runtime
+    Submitting tasks / invoking apps
+    warning: using plain-text when communicating with workers.
+    warning: use encryption with a key and cert when creating the manager.
+    All 10 tasks submitted ... waiting for completion
+    Submission took 0.008 seconds = 1248.676 tasks/second
+    Runtime: actual 3.668s vs target 120s
+    Tasks per second: 2.726
+
+    [...]
+
+    ==== Iteration 4 ====
+    Will run 57640 tasks to target 120 seconds runtime
+    Submitting tasks / invoking apps
+    All 57640 tasks submitted ... waiting for completion
+    Submission took 34.839 seconds = 1654.487 tasks/second
+    Runtime: actual 364.387s vs target 120s
+    Tasks per second: 158.184
+    Cleaning up DFK
+    The end
+    

From c78926218a3bd4af45430f5ff04a0dc7beba4356 Mon Sep 17 00:00:00 2001
From: Ben Clifford <benc@hawaga.org.uk>
Date: Thu, 21 Sep 2023 10:39:03 +0100
Subject: [PATCH 2/2] Switch empty dfk() error from ConfigurationError to
 NoDataFlowKernelError (#2890)

This is in support of
https://github.com/Parsl/parsl/issues/2873#issuecomment-1726540856
---
 parsl/dataflow/dflow.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parsl/dataflow/dflow.py b/parsl/dataflow/dflow.py
index e51d6dd39a..c42d536c70 100644
--- a/parsl/dataflow/dflow.py
+++ b/parsl/dataflow/dflow.py
@@ -1438,5 +1438,5 @@ def wait_for_current_tasks(cls) -> None:
     def dfk(cls) -> DataFlowKernel:
         """Return the currently-loaded DataFlowKernel."""
         if cls._dfk is None:
-            raise ConfigurationError('Must first load config')
+            raise NoDataFlowKernelError('Must first load config')
         return cls._dfk