The contract should fail on Insufficient storage paid error

[agafox]

Hi,

I wanted to ask about the following contract behavior: https://explorer.mainnet.near.org/transactions/FiMZPjsEM6hWsN6eQKXC76NLtcjYsKtjtuV1QxhmSJy1#B2oVvbf8xcEyiALYPv6Ks2oGExWvr9pjuP9WHhkGFBb1

As you can see the corresponding function call is not failed however NFT listing didn't happen because of the Insufficient storage paid: 34360000000000000000000, for 5 sales at 8590000000000000000000 rate of per sale error.

I think it will be better to fail nft_on_approve function call instead of just returning: https://github.com/ParasHQ/paras-marketplace-contract/blob/master/paras-marketplace-contract/src/nft_callbacks.rs#L171

If you agree. I can prepare a PR to fix this.

Kind regards,
Oleg

[emarai]

Hi, thanks for the input. We have been audited for the latest commit (https://guide.paras.id/faq/audits). And further improvement will not be on the current mainnet contract. However, you can still raise a PR for other projects to use.