chore(deps): typescript from 5.5.4 to 5.6.2 #2538

[iamamritpalrandhawa]

fixes: #2538

Summary by CodeRabbit

• New Features

  • Improved venue name validation in the venue creation process, ensuring better error handling for invalid inputs.

• Chores

  • Updated typescript dependency to version ^5.6.2.
  • Added @parcel/watcher dependency to the project.

[coderabbitai]

Walkthrough

The pull request introduces updates to the package.json file, including a version upgrade for the typescript dependency from ^5.5.4 to ^5.6.2 and the addition of @parcel/watcher to devDependencies. Additionally, the createVenue mutation resolver is modified to enhance venue name validation by simplifying the check for empty strings. The overall structure and functionality of the resolver are preserved, ensuring consistent error handling and return values.

Changes

Files	Change Summary
package.json	Updated typescript from ^5.5.4 to ^5.6.2 and added @parcel/watcher as a new dependency with version ^2.4.1.
src/resolvers/Mutation/createVenue.ts	Simplified venue name validation check in the createVenue mutation resolver while maintaining existing functionality.

Assessment against linked issues

Objective	Addressed	Explanation
Upgrade package typescript from 5.5.4 to 5.6.2 (#2538)	✅
Ensure existing functionality is preserved (#2538)	✅

Poem

In fields of code, a rabbit hops,
With upgrades bright, it never stops.
TypeScript shines, a version new,
A venue's name, validated true.
With every change, we dance and play,
In the land of code, we leap all day! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)

src/resolvers/Mutation/createVenue.ts (1)

114-114: Approve the simplification with a minor suggestion.

The simplification of the condition improves readability and maintains the intended functionality. It correctly handles cases where the name is undefined, null, or an empty string.

Consider trimming the input to handle cases where the name might consist only of whitespace:

-if (!args.data?.name) {
+if (!args.data?.name?.trim()) {
  throw new errors.InputValidationError(
    requestContext.translate(VENUE_NAME_MISSING_ERROR.MESSAGE),
    VENUE_NAME_MISSING_ERROR.CODE,
    VENUE_NAME_MISSING_ERROR.PARAM,
  );
}

This change ensures that strings containing only whitespace are also considered invalid.

package.json (2)

Line range hint 27-27: Remove redundant @parcel/watcher dependency

The @parcel/watcher package has been added to both dependencies and devDependencies. This is redundant and could lead to confusion. Since this package is typically used for file watching in development environments, it should only be listed in devDependencies.

Please remove the @parcel/watcher entry from the dependencies section:

-  "@parcel/watcher": "^2.4.1",

Keep it only in the devDependencies section.

Also applies to: 139-139

---

Line range hint 1-159: Review TypeScript 5.6 changelog and update codebase accordingly

While the TypeScript upgrade is approved, it's important to review the changes introduced in version 5.6 and ensure that the codebase takes advantage of new features or addresses any deprecations.

Please follow these steps:

1. Review the TypeScript 5.6 release notes.
2. Identify any new features or syntax improvements that could benefit the project.
3. Check for any deprecations or breaking changes that might affect the current codebase.
4. Update the codebase to leverage new features and address any deprecations.
5. Consider running a codemod tool to automate some of the updates if available.

After completing these steps, please update the PR with any additional changes made to the codebase as a result of this review.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 96d609b and 5c71674.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

• package.json (1 hunks)
• src/resolvers/Mutation/createVenue.ts (1 hunks)

🔇 Additional comments (2)

src/resolvers/Mutation/createVenue.ts (1)

Line range hint 1-161: Verify TypeScript 5.6.2 compatibility.

The changes in this file appear to be unrelated to the TypeScript upgrade mentioned in the PR objectives. However, it's important to ensure that the upgrade from TypeScript 5.5.4 to 5.6.2 doesn't introduce any compatibility issues or new type checking errors in this file.

Please run the following command to check for any TypeScript errors in this file:

If any errors are reported, they should be addressed as part of this PR.

package.json (1)

144-144: Approved: TypeScript upgrade to 5.6.2

The upgrade of TypeScript from version 5.5.4 to 5.6.2 aligns with the PR objectives. This minor version upgrade should introduce new features and bug fixes without breaking changes.

To ensure compatibility, please run the following verification steps:

If any issues are encountered during these steps, please address them before merging this PR.

[palisadoes]

There isn’t an issue assigned to you for this PR. Please follow the guidelines in our PR_GUIDELINES.md file. We have the procedures in place so that everyone has a fair chance of contributing. I will be closing this pull request. Please follow the procedures and resubmit when ready.