Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing workflow of TS compilation #2472

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix failing workflow of TS compilation #2472

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7aca951
fix workflows failing of TS and lint
varshith257 Nov 25, 2024
c4f6580
Update pull-request.yml
varshith257 Nov 25, 2024
75930cd
Update pull-request.yml
varshith257 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Check for linting errors in modified files
if: steps.changed-files.outputs.only_changed != 'true'
env:
CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }}
varshith257 marked this conversation as resolved.
Show resolved Hide resolved
run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py

- name: Check for TSDoc comments
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:

- name: TypeScript compilation for changed files
run: |
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
for file in ${{ steps.changed-files.outputs.all_files }}; do
if [[ "$file" == *.ts || "$file" == *.tsx ]]; then
npx tsc --noEmit "$file"
fi
Expand Down
Loading