Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: Integrated Dicebear Library To Enhance Security" #1634

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Revert "feat: Integrated Dicebear Library To Enhance Security" #1634

merged 1 commit into from
Feb 28, 2024

Conversation

palisadoes
Copy link
Contributor

Reverts #1585

@palisadoes palisadoes merged commit ebcc977 into develop Feb 28, 2024
10 of 12 checks passed
@github-actions GitHub Actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes palisadoes mentioned this pull request Feb 28, 2024
Merged
@palisadoes palisadoes deleted the revert-1585-feat/dicebear-integration-avatar branch February 28, 2024 21:55
AVtheking added a commit to AVtheking/talawa-admin that referenced this pull request Feb 29, 2024
@AVtheking
Squashed commit of the following:
523b0bd 
commit 6e157db
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:49:06 2024 -0800

    Revert "Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)…" (PalisadoesFoundation#1635)

    This reverts commit ebcc977.

commit ebcc977
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:47:08 2024 -0800

    Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)" (PalisadoesFoundation#1634)

    This reverts commit 7828c40.

commit da8df05
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:46:19 2024 -0800

    Revert "Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)" (PalisadoesFoundation#1633)

    This reverts commit 22bdfa9.

commit 22bdfa9
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:44:15 2024 -0800

    Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)

    This reverts commit a71db3b.

commit a71db3b
Author: Meetul Rathore <[email protected]>
Date:   Thu Feb 29 00:24:58 2024 +0530

    feat: Add support for Action Items (PalisadoesFoundation#1596)

    * add mutations and queries

    * add translations

    * add tests

    * add dropdown for toggling settings on small screens

    * minor corrections

    * minor change

    * initial changes

    * basic design

    * add basic modals

    * add create action item functionality

    * add update functionality

    * add delete functionality

    * add details modal

    * extract modals and restructure

    * add sorting

    * remove unnecessary files

    * add filters and design adjustments

    * add translations

    * don't show disabled action item categories

    * add tests for OrganizationActionItems.tsx

    * add tests for ActionItemContainer.tsx

    * add filters section

    * minor adjustments

    * move mutations and queries into separate files

    * fix failing test

    * format files

    * use css variables for colors

    * write test for IconComponent.tsx

commit 7828c40
Author: Akhilender Bongirwar <[email protected]>
Date:   Wed Feb 28 17:59:21 2024 +0530

    feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)

    * feat: Integrated Dicebear Library To Enhance Security

    - Added the Dicebear library as a dependency to the project.
    - Imported the necessary functions from the library.
    - Created a new `Avatar` component that utilizes the Dicebear library locally.
    - Updated the component to accept `name`, `alt`, and `size` as props.
    - Utilized the Dicebear library to generate avatars with initials.
    - Removed direct HTTP API calls from the codebase.
    - Replaced instances of direct HTTP API calls with the newly created `Avatar` component.
    - Updated the exisiting tests and ensured the tests are still valid.
    - Mitigated security risks associated with SSRF and XSS attacks by eliminating direct HTTP API calls.
    - By using the Dicebear library locally, we reduce potential vulnerabilities.
    - Ensured no other functionality is affected.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Reverted changes in the tests

    - Reverted the Avatar component in all the tests as they are redundant in tests except where it is needed.
    - Ensured all the remaning tests are succesfully passing.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Added dynamic style

    - Handled case where no alt tag is provided by adding default alt value.
    - dynamic rendering for className for img tag in avatar component
    - Dynamic rendering for test-id
    - Replaced suitable changes for the above properties added

    Signed-off-by: Akhilender <[email protected]>

    * fix: modified test

    Signed-off-by: Akhilender <[email protected]>

    * fix: resolved conflict

    Signed-off-by: Akhilender <[email protected]>

    ---------

    Signed-off-by: Akhilender <[email protected]>

commit 092b9f6
Author: Disha Talreja <[email protected]>
Date:   Tue Feb 27 23:13:24 2024 +0530

    feat: implemented support to upload media while creating and updating advertisements (PalisadoesFoundation#1529)

    * feat: implemented support to upload media in advertisement register component

    * fix: failing tests

    * fix: failing tests

    * removed commented code

    * fix: failing tests

    * renamed link variable to mediaUrl

    * updated the type of mediaUrl

    * updated schema and mutation for createAdvertisement

    * removed unused variables

    * Added support to display advertisement image/video in user portal

    * fix: failing tests

    * fix: failing tests

    * reverted unwanted changes

    * fix: failing tests

    * fix: failing tests

    * added translations for different languages and improved variable names

    * Updated variable name and input fields for creating advertisements

    * fix: failing tests

    * fix: failing tests

    * updated get advertisement query

    * fix: update advertisement feature

    * removed unwanted curly braces

    * fix failing tests

    * updated type of file

    * fix: formatting issues

    * fix: formatting issues

    * updated variable name and fix cross origin error

    * removed: unwanted curly braces

    * fix: failing tests

    * added oragnization resolver for advertisement

    * removed unwanted code

    * fix: failing tests

    * fix: formatting issues

    * fix: formatting issues

    * fix: formatting issues

    * fix: failing tests

    * fix: advertisements not rendering

    * fix: removed unused imports

    * fix: linting errors

    * Update documentation

    * Updated mutation to delete advertisement

    * Update documentation

    * fix: formatting issues

    * fix: type error

    * fix: lint errors

    * fix: error

    * fix: advertisements not rendering on user portal

    * fix: not same origin error while rendering video

    * Updated deleteAdvertisement mutation and advertisementsConnection mutation

    * fix: failing tests

commit 9ffa02b
Author: Peter Harrison <[email protected]>
Date:   Tue Feb 27 09:19:26 2024 -0800

    Enforce Node v20

commit 9d2689a
Author: Anvita Mahajan <[email protected]>
Date:   Tue Feb 27 22:21:20 2024 +0530

    Increased code coverage for src/components/AddOn/core/AddOnStore/AddOnStore.tsx file (PalisadoesFoundation#1614)

    * Added tests for AddOnStore/AddOnStore.tsx

    * Fixed linting errors

    * Fixed warnings due to linting errors

    * Removed commented code
palisadoes pushed a commit that referenced this pull request Mar 1, 2024
@AVtheking
Fix/postsby org (#1639)
f16aefe 
* fix postByConnectionQuery

* Squashed commit of the following:

commit 6e157db
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:49:06 2024 -0800

    Revert "Revert "feat: Integrated Dicebear Library To Enhance Security (#1585)…" (#1635)

    This reverts commit ebcc977.

commit ebcc977
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:47:08 2024 -0800

    Revert "feat: Integrated Dicebear Library To Enhance Security (#1585)" (#1634)

    This reverts commit 7828c40.

commit da8df05
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:46:19 2024 -0800

    Revert "Revert "feat: Add support for Action Items (#1596)" (#1632)" (#1633)

    This reverts commit 22bdfa9.

commit 22bdfa9
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:44:15 2024 -0800

    Revert "feat: Add support for Action Items (#1596)" (#1632)

    This reverts commit a71db3b.

commit a71db3b
Author: Meetul Rathore <[email protected]>
Date:   Thu Feb 29 00:24:58 2024 +0530

    feat: Add support for Action Items (#1596)

    * add mutations and queries

    * add translations

    * add tests

    * add dropdown for toggling settings on small screens

    * minor corrections

    * minor change

    * initial changes

    * basic design

    * add basic modals

    * add create action item functionality

    * add update functionality

    * add delete functionality

    * add details modal

    * extract modals and restructure

    * add sorting

    * remove unnecessary files

    * add filters and design adjustments

    * add translations

    * don't show disabled action item categories

    * add tests for OrganizationActionItems.tsx

    * add tests for ActionItemContainer.tsx

    * add filters section

    * minor adjustments

    * move mutations and queries into separate files

    * fix failing test

    * format files

    * use css variables for colors

    * write test for IconComponent.tsx

commit 7828c40
Author: Akhilender Bongirwar <[email protected]>
Date:   Wed Feb 28 17:59:21 2024 +0530

    feat: Integrated Dicebear Library To Enhance Security (#1585)

    * feat: Integrated Dicebear Library To Enhance Security

    - Added the Dicebear library as a dependency to the project.
    - Imported the necessary functions from the library.
    - Created a new `Avatar` component that utilizes the Dicebear library locally.
    - Updated the component to accept `name`, `alt`, and `size` as props.
    - Utilized the Dicebear library to generate avatars with initials.
    - Removed direct HTTP API calls from the codebase.
    - Replaced instances of direct HTTP API calls with the newly created `Avatar` component.
    - Updated the exisiting tests and ensured the tests are still valid.
    - Mitigated security risks associated with SSRF and XSS attacks by eliminating direct HTTP API calls.
    - By using the Dicebear library locally, we reduce potential vulnerabilities.
    - Ensured no other functionality is affected.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Reverted changes in the tests

    - Reverted the Avatar component in all the tests as they are redundant in tests except where it is needed.
    - Ensured all the remaning tests are succesfully passing.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Added dynamic style

    - Handled case where no alt tag is provided by adding default alt value.
    - dynamic rendering for className for img tag in avatar component
    - Dynamic rendering for test-id
    - Replaced suitable changes for the above properties added

    Signed-off-by: Akhilender <[email protected]>

    * fix: modified test

    Signed-off-by: Akhilender <[email protected]>

    * fix: resolved conflict

    Signed-off-by: Akhilender <[email protected]>

    ---------

    Signed-off-by: Akhilender <[email protected]>

commit 092b9f6
Author: Disha Talreja <[email protected]>
Date:   Tue Feb 27 23:13:24 2024 +0530

    feat: implemented support to upload media while creating and updating advertisements (#1529)

    * feat: implemented support to upload media in advertisement register component

    * fix: failing tests

    * fix: failing tests

    * removed commented code

    * fix: failing tests

    * renamed link variable to mediaUrl

    * updated the type of mediaUrl

    * updated schema and mutation for createAdvertisement

    * removed unused variables

    * Added support to display advertisement image/video in user portal

    * fix: failing tests

    * fix: failing tests

    * reverted unwanted changes

    * fix: failing tests

    * fix: failing tests

    * added translations for different languages and improved variable names

    * Updated variable name and input fields for creating advertisements

    * fix: failing tests

    * fix: failing tests

    * updated get advertisement query

    * fix: update advertisement feature

    * removed unwanted curly braces

    * fix failing tests

    * updated type of file

    * fix: formatting issues

    * fix: formatting issues

    * updated variable name and fix cross origin error

    * removed: unwanted curly braces

    * fix: failing tests

    * added oragnization resolver for advertisement

    * removed unwanted code

    * fix: failing tests

    * fix: formatting issues

    * fix: formatting issues

    * fix: formatting issues

    * fix: failing tests

    * fix: advertisements not rendering

    * fix: removed unused imports

    * fix: linting errors

    * Update documentation

    * Updated mutation to delete advertisement

    * Update documentation

    * fix: formatting issues

    * fix: type error

    * fix: lint errors

    * fix: error

    * fix: advertisements not rendering on user portal

    * fix: not same origin error while rendering video

    * Updated deleteAdvertisement mutation and advertisementsConnection mutation

    * fix: failing tests

commit 9ffa02b
Author: Peter Harrison <[email protected]>
Date:   Tue Feb 27 09:19:26 2024 -0800

    Enforce Node v20

commit 9d2689a
Author: Anvita Mahajan <[email protected]>
Date:   Tue Feb 27 22:21:20 2024 +0530

    Increased code coverage for src/components/AddOn/core/AddOnStore/AddOnStore.tsx file (#1614)

    * Added tests for AddOnStore/AddOnStore.tsx

    * Fixed linting errors

    * Fixed warnings due to linting errors

    * Removed commented code

* fix formatting error

* fix

* added test
palisadoes pushed a commit that referenced this pull request Mar 5, 2024
@AVtheking
Feat/funds (#1664)
e186ed2 
* fix postByConnectionQuery

* Squashed commit of the following:

commit 6e157db
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:49:06 2024 -0800

    Revert "Revert "feat: Integrated Dicebear Library To Enhance Security (#1585)…" (#1635)

    This reverts commit ebcc977.

commit ebcc977
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:47:08 2024 -0800

    Revert "feat: Integrated Dicebear Library To Enhance Security (#1585)" (#1634)

    This reverts commit 7828c40.

commit da8df05
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:46:19 2024 -0800

    Revert "Revert "feat: Add support for Action Items (#1596)" (#1632)" (#1633)

    This reverts commit 22bdfa9.

commit 22bdfa9
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:44:15 2024 -0800

    Revert "feat: Add support for Action Items (#1596)" (#1632)

    This reverts commit a71db3b.

commit a71db3b
Author: Meetul Rathore <[email protected]>
Date:   Thu Feb 29 00:24:58 2024 +0530

    feat: Add support for Action Items (#1596)

    * add mutations and queries

    * add translations

    * add tests

    * add dropdown for toggling settings on small screens

    * minor corrections

    * minor change

    * initial changes

    * basic design

    * add basic modals

    * add create action item functionality

    * add update functionality

    * add delete functionality

    * add details modal

    * extract modals and restructure

    * add sorting

    * remove unnecessary files

    * add filters and design adjustments

    * add translations

    * don't show disabled action item categories

    * add tests for OrganizationActionItems.tsx

    * add tests for ActionItemContainer.tsx

    * add filters section

    * minor adjustments

    * move mutations and queries into separate files

    * fix failing test

    * format files

    * use css variables for colors

    * write test for IconComponent.tsx

commit 7828c40
Author: Akhilender Bongirwar <[email protected]>
Date:   Wed Feb 28 17:59:21 2024 +0530

    feat: Integrated Dicebear Library To Enhance Security (#1585)

    * feat: Integrated Dicebear Library To Enhance Security

    - Added the Dicebear library as a dependency to the project.
    - Imported the necessary functions from the library.
    - Created a new `Avatar` component that utilizes the Dicebear library locally.
    - Updated the component to accept `name`, `alt`, and `size` as props.
    - Utilized the Dicebear library to generate avatars with initials.
    - Removed direct HTTP API calls from the codebase.
    - Replaced instances of direct HTTP API calls with the newly created `Avatar` component.
    - Updated the exisiting tests and ensured the tests are still valid.
    - Mitigated security risks associated with SSRF and XSS attacks by eliminating direct HTTP API calls.
    - By using the Dicebear library locally, we reduce potential vulnerabilities.
    - Ensured no other functionality is affected.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Reverted changes in the tests

    - Reverted the Avatar component in all the tests as they are redundant in tests except where it is needed.
    - Ensured all the remaning tests are succesfully passing.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Added dynamic style

    - Handled case where no alt tag is provided by adding default alt value.
    - dynamic rendering for className for img tag in avatar component
    - Dynamic rendering for test-id
    - Replaced suitable changes for the above properties added

    Signed-off-by: Akhilender <[email protected]>

    * fix: modified test

    Signed-off-by: Akhilender <[email protected]>

    * fix: resolved conflict

    Signed-off-by: Akhilender <[email protected]>

    ---------

    Signed-off-by: Akhilender <[email protected]>

commit 092b9f6
Author: Disha Talreja <[email protected]>
Date:   Tue Feb 27 23:13:24 2024 +0530

    feat: implemented support to upload media while creating and updating advertisements (#1529)

    * feat: implemented support to upload media in advertisement register component

    * fix: failing tests

    * fix: failing tests

    * removed commented code

    * fix: failing tests

    * renamed link variable to mediaUrl

    * updated the type of mediaUrl

    * updated schema and mutation for createAdvertisement

    * removed unused variables

    * Added support to display advertisement image/video in user portal

    * fix: failing tests

    * fix: failing tests

    * reverted unwanted changes

    * fix: failing tests

    * fix: failing tests

    * added translations for different languages and improved variable names

    * Updated variable name and input fields for creating advertisements

    * fix: failing tests

    * fix: failing tests

    * updated get advertisement query

    * fix: update advertisement feature

    * removed unwanted curly braces

    * fix failing tests

    * updated type of file

    * fix: formatting issues

    * fix: formatting issues

    * updated variable name and fix cross origin error

    * removed: unwanted curly braces

    * fix: failing tests

    * added oragnization resolver for advertisement

    * removed unwanted code

    * fix: failing tests

    * fix: formatting issues

    * fix: formatting issues

    * fix: formatting issues

    * fix: failing tests

    * fix: advertisements not rendering

    * fix: removed unused imports

    * fix: linting errors

    * Update documentation

    * Updated mutation to delete advertisement

    * Update documentation

    * fix: formatting issues

    * fix: type error

    * fix: lint errors

    * fix: error

    * fix: advertisements not rendering on user portal

    * fix: not same origin error while rendering video

    * Updated deleteAdvertisement mutation and advertisementsConnection mutation

    * fix: failing tests

commit 9ffa02b
Author: Peter Harrison <[email protected]>
Date:   Tue Feb 27 09:19:26 2024 -0800

    Enforce Node v20

commit 9d2689a
Author: Anvita Mahajan <[email protected]>
Date:   Tue Feb 27 22:21:20 2024 +0530

    Increased code coverage for src/components/AddOn/core/AddOnStore/AddOnStore.tsx file (#1614)

    * Added tests for AddOnStore/AddOnStore.tsx

    * Fixed linting errors

    * Fixed warnings due to linting errors

    * Removed commented code

* fix formatting error

* fix

* added test

* created fund screen

* added update fund feature

* funds feature completed

* added tests

* fix test

* merged develop

* fix deletion error

* fix

* remove unwanted file

* remove unwanted file

* remove unwanted file

* added doc for remove fund mutation

* fixed eslint

* fixed eslint

* fix

* removed unwanted file

* fix formatting error

* fix faiing test
kanhaiya04 pushed a commit to kanhaiya04/talawa-admin that referenced this pull request Mar 5, 2024
@AVtheking @kanhaiya04
Feat/funds (PalisadoesFoundation#1664)
4340b09 
* fix postByConnectionQuery

* Squashed commit of the following:

commit 6e157db
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:49:06 2024 -0800

    Revert "Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)…" (PalisadoesFoundation#1635)

    This reverts commit ebcc977.

commit ebcc977
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:47:08 2024 -0800

    Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)" (PalisadoesFoundation#1634)

    This reverts commit 7828c40.

commit da8df05
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:46:19 2024 -0800

    Revert "Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)" (PalisadoesFoundation#1633)

    This reverts commit 22bdfa9.

commit 22bdfa9
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:44:15 2024 -0800

    Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)

    This reverts commit a71db3b.

commit a71db3b
Author: Meetul Rathore <[email protected]>
Date:   Thu Feb 29 00:24:58 2024 +0530

    feat: Add support for Action Items (PalisadoesFoundation#1596)

    * add mutations and queries

    * add translations

    * add tests

    * add dropdown for toggling settings on small screens

    * minor corrections

    * minor change

    * initial changes

    * basic design

    * add basic modals

    * add create action item functionality

    * add update functionality

    * add delete functionality

    * add details modal

    * extract modals and restructure

    * add sorting

    * remove unnecessary files

    * add filters and design adjustments

    * add translations

    * don't show disabled action item categories

    * add tests for OrganizationActionItems.tsx

    * add tests for ActionItemContainer.tsx

    * add filters section

    * minor adjustments

    * move mutations and queries into separate files

    * fix failing test

    * format files

    * use css variables for colors

    * write test for IconComponent.tsx

commit 7828c40
Author: Akhilender Bongirwar <[email protected]>
Date:   Wed Feb 28 17:59:21 2024 +0530

    feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)

    * feat: Integrated Dicebear Library To Enhance Security

    - Added the Dicebear library as a dependency to the project.
    - Imported the necessary functions from the library.
    - Created a new `Avatar` component that utilizes the Dicebear library locally.
    - Updated the component to accept `name`, `alt`, and `size` as props.
    - Utilized the Dicebear library to generate avatars with initials.
    - Removed direct HTTP API calls from the codebase.
    - Replaced instances of direct HTTP API calls with the newly created `Avatar` component.
    - Updated the exisiting tests and ensured the tests are still valid.
    - Mitigated security risks associated with SSRF and XSS attacks by eliminating direct HTTP API calls.
    - By using the Dicebear library locally, we reduce potential vulnerabilities.
    - Ensured no other functionality is affected.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Reverted changes in the tests

    - Reverted the Avatar component in all the tests as they are redundant in tests except where it is needed.
    - Ensured all the remaning tests are succesfully passing.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Added dynamic style

    - Handled case where no alt tag is provided by adding default alt value.
    - dynamic rendering for className for img tag in avatar component
    - Dynamic rendering for test-id
    - Replaced suitable changes for the above properties added

    Signed-off-by: Akhilender <[email protected]>

    * fix: modified test

    Signed-off-by: Akhilender <[email protected]>

    * fix: resolved conflict

    Signed-off-by: Akhilender <[email protected]>

    ---------

    Signed-off-by: Akhilender <[email protected]>

commit 092b9f6
Author: Disha Talreja <[email protected]>
Date:   Tue Feb 27 23:13:24 2024 +0530

    feat: implemented support to upload media while creating and updating advertisements (PalisadoesFoundation#1529)

    * feat: implemented support to upload media in advertisement register component

    * fix: failing tests

    * fix: failing tests

    * removed commented code

    * fix: failing tests

    * renamed link variable to mediaUrl

    * updated the type of mediaUrl

    * updated schema and mutation for createAdvertisement

    * removed unused variables

    * Added support to display advertisement image/video in user portal

    * fix: failing tests

    * fix: failing tests

    * reverted unwanted changes

    * fix: failing tests

    * fix: failing tests

    * added translations for different languages and improved variable names

    * Updated variable name and input fields for creating advertisements

    * fix: failing tests

    * fix: failing tests

    * updated get advertisement query

    * fix: update advertisement feature

    * removed unwanted curly braces

    * fix failing tests

    * updated type of file

    * fix: formatting issues

    * fix: formatting issues

    * updated variable name and fix cross origin error

    * removed: unwanted curly braces

    * fix: failing tests

    * added oragnization resolver for advertisement

    * removed unwanted code

    * fix: failing tests

    * fix: formatting issues

    * fix: formatting issues

    * fix: formatting issues

    * fix: failing tests

    * fix: advertisements not rendering

    * fix: removed unused imports

    * fix: linting errors

    * Update documentation

    * Updated mutation to delete advertisement

    * Update documentation

    * fix: formatting issues

    * fix: type error

    * fix: lint errors

    * fix: error

    * fix: advertisements not rendering on user portal

    * fix: not same origin error while rendering video

    * Updated deleteAdvertisement mutation and advertisementsConnection mutation

    * fix: failing tests

commit 9ffa02b
Author: Peter Harrison <[email protected]>
Date:   Tue Feb 27 09:19:26 2024 -0800

    Enforce Node v20

commit 9d2689a
Author: Anvita Mahajan <[email protected]>
Date:   Tue Feb 27 22:21:20 2024 +0530

    Increased code coverage for src/components/AddOn/core/AddOnStore/AddOnStore.tsx file (PalisadoesFoundation#1614)

    * Added tests for AddOnStore/AddOnStore.tsx

    * Fixed linting errors

    * Fixed warnings due to linting errors

    * Removed commented code

* fix formatting error

* fix

* added test

* created fund screen

* added update fund feature

* funds feature completed

* added tests

* fix test

* merged develop

* fix deletion error

* fix

* remove unwanted file

* remove unwanted file

* remove unwanted file

* added doc for remove fund mutation

* fixed eslint

* fixed eslint

* fix

* removed unwanted file

* fix formatting error

* fix faiing test
kanhaiya04 pushed a commit to kanhaiya04/talawa-admin that referenced this pull request Mar 5, 2024
@AVtheking @kanhaiya04
Feat/funds (PalisadoesFoundation#1664)
25aa1fb 
* fix postByConnectionQuery

* Squashed commit of the following:

commit 6e157db
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:49:06 2024 -0800

    Revert "Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)…" (PalisadoesFoundation#1635)

    This reverts commit ebcc977.

commit ebcc977
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:47:08 2024 -0800

    Revert "feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)" (PalisadoesFoundation#1634)

    This reverts commit 7828c40.

commit da8df05
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:46:19 2024 -0800

    Revert "Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)" (PalisadoesFoundation#1633)

    This reverts commit 22bdfa9.

commit 22bdfa9
Author: Peter Harrison <[email protected]>
Date:   Wed Feb 28 13:44:15 2024 -0800

    Revert "feat: Add support for Action Items (PalisadoesFoundation#1596)" (PalisadoesFoundation#1632)

    This reverts commit a71db3b.

commit a71db3b
Author: Meetul Rathore <[email protected]>
Date:   Thu Feb 29 00:24:58 2024 +0530

    feat: Add support for Action Items (PalisadoesFoundation#1596)

    * add mutations and queries

    * add translations

    * add tests

    * add dropdown for toggling settings on small screens

    * minor corrections

    * minor change

    * initial changes

    * basic design

    * add basic modals

    * add create action item functionality

    * add update functionality

    * add delete functionality

    * add details modal

    * extract modals and restructure

    * add sorting

    * remove unnecessary files

    * add filters and design adjustments

    * add translations

    * don't show disabled action item categories

    * add tests for OrganizationActionItems.tsx

    * add tests for ActionItemContainer.tsx

    * add filters section

    * minor adjustments

    * move mutations and queries into separate files

    * fix failing test

    * format files

    * use css variables for colors

    * write test for IconComponent.tsx

commit 7828c40
Author: Akhilender Bongirwar <[email protected]>
Date:   Wed Feb 28 17:59:21 2024 +0530

    feat: Integrated Dicebear Library To Enhance Security (PalisadoesFoundation#1585)

    * feat: Integrated Dicebear Library To Enhance Security

    - Added the Dicebear library as a dependency to the project.
    - Imported the necessary functions from the library.
    - Created a new `Avatar` component that utilizes the Dicebear library locally.
    - Updated the component to accept `name`, `alt`, and `size` as props.
    - Utilized the Dicebear library to generate avatars with initials.
    - Removed direct HTTP API calls from the codebase.
    - Replaced instances of direct HTTP API calls with the newly created `Avatar` component.
    - Updated the exisiting tests and ensured the tests are still valid.
    - Mitigated security risks associated with SSRF and XSS attacks by eliminating direct HTTP API calls.
    - By using the Dicebear library locally, we reduce potential vulnerabilities.
    - Ensured no other functionality is affected.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Reverted changes in the tests

    - Reverted the Avatar component in all the tests as they are redundant in tests except where it is needed.
    - Ensured all the remaning tests are succesfully passing.

    Signed-off-by: Akhilender <[email protected]>

    * fix: Added dynamic style

    - Handled case where no alt tag is provided by adding default alt value.
    - dynamic rendering for className for img tag in avatar component
    - Dynamic rendering for test-id
    - Replaced suitable changes for the above properties added

    Signed-off-by: Akhilender <[email protected]>

    * fix: modified test

    Signed-off-by: Akhilender <[email protected]>

    * fix: resolved conflict

    Signed-off-by: Akhilender <[email protected]>

    ---------

    Signed-off-by: Akhilender <[email protected]>

commit 092b9f6
Author: Disha Talreja <[email protected]>
Date:   Tue Feb 27 23:13:24 2024 +0530

    feat: implemented support to upload media while creating and updating advertisements (PalisadoesFoundation#1529)

    * feat: implemented support to upload media in advertisement register component

    * fix: failing tests

    * fix: failing tests

    * removed commented code

    * fix: failing tests

    * renamed link variable to mediaUrl

    * updated the type of mediaUrl

    * updated schema and mutation for createAdvertisement

    * removed unused variables

    * Added support to display advertisement image/video in user portal

    * fix: failing tests

    * fix: failing tests

    * reverted unwanted changes

    * fix: failing tests

    * fix: failing tests

    * added translations for different languages and improved variable names

    * Updated variable name and input fields for creating advertisements

    * fix: failing tests

    * fix: failing tests

    * updated get advertisement query

    * fix: update advertisement feature

    * removed unwanted curly braces

    * fix failing tests

    * updated type of file

    * fix: formatting issues

    * fix: formatting issues

    * updated variable name and fix cross origin error

    * removed: unwanted curly braces

    * fix: failing tests

    * added oragnization resolver for advertisement

    * removed unwanted code

    * fix: failing tests

    * fix: formatting issues

    * fix: formatting issues

    * fix: formatting issues

    * fix: failing tests

    * fix: advertisements not rendering

    * fix: removed unused imports

    * fix: linting errors

    * Update documentation

    * Updated mutation to delete advertisement

    * Update documentation

    * fix: formatting issues

    * fix: type error

    * fix: lint errors

    * fix: error

    * fix: advertisements not rendering on user portal

    * fix: not same origin error while rendering video

    * Updated deleteAdvertisement mutation and advertisementsConnection mutation

    * fix: failing tests

commit 9ffa02b
Author: Peter Harrison <[email protected]>
Date:   Tue Feb 27 09:19:26 2024 -0800

    Enforce Node v20

commit 9d2689a
Author: Anvita Mahajan <[email protected]>
Date:   Tue Feb 27 22:21:20 2024 +0530

    Increased code coverage for src/components/AddOn/core/AddOnStore/AddOnStore.tsx file (PalisadoesFoundation#1614)

    * Added tests for AddOnStore/AddOnStore.tsx

    * Fixed linting errors

    * Fixed warnings due to linting errors

    * Removed commented code

* fix formatting error

* fix

* added test

* created fund screen

* added update fund feature

* funds feature completed

* added tests

* fix test

* merged develop

* fix deletion error

* fix

* remove unwanted file

* remove unwanted file

* remove unwanted file

* added doc for remove fund mutation

* fixed eslint

* fixed eslint

* fix

* removed unwanted file

* fix formatting error

* fix faiing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@palisadoes