-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the scroll Bar of the event calendar and the side navbar. #1580
Updated the scroll Bar of the event calendar and the side navbar. #1580
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1580 +/- ##
========================================
Coverage 96.74% 96.74%
========================================
Files 138 138
Lines 3688 3688
Branches 1123 1125 +2
========================================
Hits 3568 3568
+ Misses 115 114 -1
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
@Kevoniat @anwersayeed Can you review this PR? |
@aashimawadhwa @rishav-jha-mech, can you please review the PR ?? |
NOTE Read very carefully
This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:
This will help to reduce the number of existing and future merge conflicts for your PR. |
@@ -15,6 +15,7 @@ import { ReactComponent as TalawaLogo } from 'assets/svgs/talawa.svg'; | |||
import styles from './LeftDrawerOrg.module.css'; | |||
import { REVOKE_REFRESH_TOKEN } from 'GraphQl/Mutations/mutations'; | |||
import useLocalStorage from 'utils/useLocalstorage'; | |||
import '../../assets/css/scroll-styles.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AmitSharma512 you need to import this into /src/index.ts
file
@AmitSharma512 you missed |
src/assets/css/scroll-styles.css
Outdated
@@ -0,0 +1,18 @@ | |||
.custom-scroll { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this camelCase
, after this your PR is ready to be merged
… into Scrollbar-Redesign
@rishav-jha-mech can you please review it? |
2150bf1
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
I have updated the scroll bar of the event calendar and the side navbar.
Issue Number:
Fixes #1551
Snapshots/Videos:
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes