Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the scroll Bar of the event calendar and the side navbar. #1580

Merged

Conversation

AmitSharma512
Copy link

What kind of change does this PR introduce?

I have updated the scroll bar of the event calendar and the side navbar.

Issue Number:

Fixes #1551

Snapshots/Videos:

image

image

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a625c7) 96.74% compared to head (b664078) 96.74%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1580   +/-   ##
========================================
  Coverage    96.74%   96.74%           
========================================
  Files          138      138           
  Lines         3688     3688           
  Branches      1123     1125    +2     
========================================
  Hits          3568     3568           
+ Misses         115      114    -1     
- Partials         5        6    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link

@Kevoniat @anwersayeed Can you review this PR?

@AmitSharma512
Copy link
Author

@aashimawadhwa @rishav-jha-mech, can you please review the PR ??

@palisadoes
Copy link
Contributor

NOTE Read very carefully

  1. We just merged this PR which upgraded the prettier package.
    1. Upgraded prettier from 2.3.2 to 3.2.5 #1599
  2. It reformatted over 150 files.

This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:

  1. upgrade your prettier in your local branch to the same version
  2. run prettier on your local branch
  3. update your local branch with the latest upstream

This will help to reduce the number of existing and future merge conflicts for your PR.

@@ -15,6 +15,7 @@ import { ReactComponent as TalawaLogo } from 'assets/svgs/talawa.svg';
import styles from './LeftDrawerOrg.module.css';
import { REVOKE_REFRESH_TOKEN } from 'GraphQl/Mutations/mutations';
import useLocalStorage from 'utils/useLocalstorage';
import '../../assets/css/scroll-styles.css';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmitSharma512 you need to import this into /src/index.ts file

@rishav-jha-mech
Copy link
Contributor

@AmitSharma512 you missed src/LeftDrawer/LeftDrawer.tsx, add custom scrollbar there too

@@ -0,0 +1,18 @@
.custom-scroll {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this camelCase, after this your PR is ready to be merged

@AmitSharma512
Copy link
Author

@rishav-jha-mech can you please review it?

@palisadoes palisadoes merged commit 2150bf1 into PalisadoesFoundation:develop Feb 25, 2024
9 of 10 checks passed
@AmitSharma512 AmitSharma512 deleted the Scrollbar-Redesign branch February 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants