GitHub Action: Fix authorized-changes-detection #1543

duplixx · 2024-02-05T08:42:17Z

What kind of change does this PR introduce?

Issue Number:

Fixes #1526

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

github-actions · 2024-02-05T08:42:41Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

palisadoes

Test the following with this PR to make sure this and all other tests run:

A commit with changes to more than 20 files not in the list
A commit with a test file added to the .github directory

.github/workflows/pull-requests.yml

.github/workflows/count_changed_files.py

.github/workflows/sensitive_files.txt

palisadoes · 2024-02-05T12:50:17Z

You haven't done the tests I requested using this PR

duplixx · 2024-02-05T18:24:35Z

You haven't done the tests I requested using this PR

@palisadoes I apologize for any confusion. I am currently running tests, and I have noticed an issue related to the changed files. When printing the changed files, it shows an empty array. I believe this might be the reason why the sensitive file function is not running in this condition. Is there any change i should do to make it work

codecov · 2024-02-06T07:13:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (440387b) 96.74% compared to head (9a0a6b7) 96.74%.

❗ Current head 9a0a6b7 differs from pull request most recent head 3db0207. Consider uploading reports for the commit 3db0207 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
- Coverage    96.74%   96.74%   -0.01%     
===========================================
  Files          138      138              
  Lines         3688     3687       -1     
  Branches      1125     1125              
===========================================
- Hits          3568     3567       -1     
  Misses         114      114              
  Partials         6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

duplixx · 2024-02-06T11:56:29Z

@palisadoes i changed the fetch-depth to 1 so it can clone the file name but that also deosn't seems to be working

duplixx · 2024-02-16T17:35:35Z

@palisadoes here's the working demo of unauthorized changes workflow integrared in pull_request.yml

Screen.Recording.2024-02-16.at.11.00.57.PM.mov

palisadoes

See comments

.github/workflows/check_files.py

palisadoes · 2024-02-17T04:50:57Z

.github/workflows/check_files.py

+    if unauthorized_changes:
+        print("Error: Unauthorized changes detected. Please review the list of modified files:")
+        for file in unauthorized_changes:
+            print(f" - {file}")


You are printing the named tuple, not the files it contained. I've recommended another approach

.github/workflows/check_files.py

palisadoes · 2024-02-17T14:30:04Z

We recently updated .github/workflows/authorized-changes-detection.yml

duplixx · 2024-02-17T15:09:31Z

We recently updated .github/workflows/authorized-changes-detection.yml

it will be deleted afterwards right??

We recently updated .github/workflows/authorized-changes-detection.yml

added mentioned changes

palisadoes · 2024-02-17T15:23:53Z

Yes, .github/workflows/authorized-changes-detection.yml should be deleted

duplixx · 2024-02-17T15:30:39Z

All changes are done from my side sir @palisadoes

palisadoes

Make sure the script:

is python black, pylint, pycodestyle, flake8 and pydocstyle compliant.
Has a maximum line width of 80 for better readability.
1. https://stackoverflow.com/questions/59183863/in-python-how-to-tweak-black-formatter-if-possible

palisadoes · 2024-02-17T15:28:03Z

.github/workflows/check_files.py

+
+    changed_files = [file.strip() for file in output.split(' ') if file.strip()]
+    file_count = len(changed_files)
+    return ScriptResult(file_count=file_count, unauthorized_changes=changed_files)


Again, a named tuple isn't needed here. You are only using the file count later.

palisadoes · 2024-02-17T15:29:09Z

.github/workflows/check_files.py

+
+    # Count changed files and check for unauthorized changes
+    changed_files = _count_changed_files(base_branch, pr_branch)
+    print(f"Number of changed files: {changed_files.file_count}")


Only print if the verbose flag is set

palisadoes · 2024-02-17T19:07:56Z

Please fix the conflicting file, so that this can be merged

duplixx · 2024-02-17T19:12:15Z

Sir, @palisadoes, I have deleted this file. How should I fix the conflicts? I guess after merging the changes, the conflicts will not show up.

palisadoes · 2024-02-17T19:28:13Z

Try merging with the latest upstream and updating with a commit

palisadoes · 2024-02-17T19:42:12Z

NOTE Read very carefully

We just merged this PR which upgraded the prettier package.
1. Upgraded prettier from 2.3.2 to 3.2.5 #1599
It reformatted over 150 files.

This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:

upgrade your prettier in your local branch to the same version
run prettier on your local branch
update your local branch with the latest upstream

This will help to reduce the number of existing and future merge conflicts for your PR.

This reverts commit 6a910fc.

duplixx added 19 commits February 3, 2024 18:22

Create authorized-change.py

f85bdbb

Update authorized-changes-detection.yml

d1a2722

Update authorized-changes-detection.yml

b154a85

Update count_changed_files.py

87ed332

Update count_changed_files.py

1996dec

Update count_changed_files.py

a28c646

Create sensitive_files.txt

cdf13be

Update pull-requests.yml

5e28451

Update pull-requests.yml

da75d9b

Update pull-requests.yml

5fd02b4

Update pull-requests.yml

e80eaab

Update pull-requests.yml

c1e84de

Update pull-requests.yml

bb8bce7

Update pull-requests.yml

f1faf06

Update count_changed_files.py

380fc8d

Update count_changed_files.py

bdbc784

Update count_changed_files.py

61d2749

Delete .github/workflows/authorized-changes-detection.yml

ebee0be

Delete .github/workflows/authorized-change.py

fbcbeca

duplixx requested a review from palisadoes as a code owner February 5, 2024 08:42

palisadoes requested changes Feb 5, 2024

View reviewed changes

.github/workflows/pull-requests.yml Outdated Show resolved Hide resolved

.github/workflows/count_changed_files.py Outdated Show resolved Hide resolved

.github/workflows/sensitive_files.txt Show resolved Hide resolved

reviews changes done

72c9458

duplixx added 3 commits February 6, 2024 00:28

fetch-depth testing

f1fd544

Update pull-requests.yml

5f79568

Update check_files.py

51194b1

duplixx added 3 commits February 14, 2024 17:26

changes

dd4d3bc

..

439b9de

Merge branch 'develop' into develop

9a0a6b7

palisadoes requested changes Feb 17, 2024

View reviewed changes

duplixx added 3 commits February 17, 2024 20:29

reviewed changes

bcd6b70

optimize system exits

6c65f12

added node-version path

e43f78a

palisadoes requested changes Feb 17, 2024

View reviewed changes

black formatting added

5da16fa

palisadoes previously approved these changes Feb 17, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/develop' into develop

3db0207

duplixx dismissed palisadoes’s stale review via 3db0207 February 17, 2024 20:53

duplixx requested a review from palisadoes February 17, 2024 20:54

palisadoes approved these changes Feb 17, 2024

View reviewed changes

palisadoes merged commit 6a910fc into PalisadoesFoundation:develop Feb 17, 2024
7 of 8 checks passed

This was referenced Feb 18, 2024

API GitHub Action: Fix authorized-changes-detection PalisadoesFoundation/talawa-api#1864

Closed

Mobile GitHub Action: Fix authorized-changes-detection PalisadoesFoundation/talawa#2377

Closed

palisadoes added a commit that referenced this pull request Feb 18, 2024

Revert "GitHub Action: Fix authorized-changes-detection (#1543)"

b3f6a87

This reverts commit 6a910fc.

palisadoes mentioned this pull request Feb 18, 2024

Revert "GitHub Action: Fix authorized-changes-detection" #1601

Merged

palisadoes added a commit that referenced this pull request Feb 18, 2024

Revert "GitHub Action: Fix authorized-changes-detection (#1543)" (#1601)

25d3fe1

This reverts commit 6a910fc.

lakshz mentioned this pull request Mar 24, 2024

Update pull_request.yml to check authorized files changed as a job #1793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Action: Fix authorized-changes-detection #1543

GitHub Action: Fix authorized-changes-detection #1543

duplixx commented Feb 5, 2024

github-actions bot commented Feb 5, 2024 •

edited

Loading

palisadoes left a comment

palisadoes commented Feb 5, 2024

duplixx commented Feb 5, 2024

codecov bot commented Feb 6, 2024 •

edited

Loading

duplixx commented Feb 6, 2024 •

edited

Loading

duplixx commented Feb 16, 2024

palisadoes left a comment

palisadoes Feb 17, 2024

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes left a comment

palisadoes Feb 17, 2024

palisadoes Feb 17, 2024

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes commented Feb 17, 2024

palisadoes commented Feb 17, 2024

GitHub Action: Fix authorized-changes-detection #1543

GitHub Action: Fix authorized-changes-detection #1543

Conversation

duplixx commented Feb 5, 2024

github-actions bot commented Feb 5, 2024 • edited Loading

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

palisadoes left a comment

Choose a reason for hiding this comment

palisadoes commented Feb 5, 2024

duplixx commented Feb 5, 2024

codecov bot commented Feb 6, 2024 • edited Loading

Codecov Report

duplixx commented Feb 6, 2024 • edited Loading

duplixx commented Feb 16, 2024

palisadoes left a comment

Choose a reason for hiding this comment

palisadoes Feb 17, 2024

Choose a reason for hiding this comment

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes left a comment

Choose a reason for hiding this comment

palisadoes Feb 17, 2024

Choose a reason for hiding this comment

palisadoes Feb 17, 2024

Choose a reason for hiding this comment

palisadoes commented Feb 17, 2024

duplixx commented Feb 17, 2024

palisadoes commented Feb 17, 2024

palisadoes commented Feb 17, 2024

github-actions bot commented Feb 5, 2024 •

edited

Loading

codecov bot commented Feb 6, 2024 •

edited

Loading

duplixx commented Feb 6, 2024 •

edited

Loading