Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/UserPortal/Settings from Jest to Vitest #2579

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 7 comments
Closed
Assignees
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/UserPortal/Settings pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 1, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation feature request labels Dec 3, 2024
@Vanshjain2701
Copy link

Can you please assign me this?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 19, 2024
@palisadoes
Copy link
Contributor

Unassigning. Inactivity and no related PR

@IITI-tushar
Copy link
Contributor

@palisadoes please assign me. I want to work on this.

@Cioppolo14
Copy link
Contributor

@IITI-tushar Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@IITI-tushar
Copy link
Contributor

@IITI-tushar Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

I have unassigned myself from other issue. Please assign me this one.

@shivasankaran18
Copy link
Contributor

@palisadoes can I work on this issue ..Fixed it locally !

palisadoes pushed a commit that referenced this issue Dec 22, 2024
…2718)

* Update and rename Settings.test.tsx to Settings.spec.tsx

* Update Settings.spec.tsx- removed-deprecated-methods-suggested-by-coderabbit
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 22, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Status: Done
Development

No branches or pull requests

6 participants