Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the User/Users.tx Screen in the develop-userTypeFix branch #1684

Closed
palisadoes opened this issue Mar 8, 2024 · 5 comments
Closed

Fix the User/Users.tx Screen in the develop-userTypeFix branch #1684

palisadoes opened this issue Mar 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Mar 8, 2024

NOTE

  1. This issue will require close coordination with persons assigned issues in the reference section.
  2. This work will need to be done on the develop-userTypeFix branch

Describe the bug

  1. The schema doesn't apply a person's userType by organization.
  2. The userType is currently a part of the User definition not part of a userOrganization definition or something similar.
    1. This means that an Admin is an Admin for all organizations which grants the same rights as a SuperAdmin. This is not the intention.
    2. This has created historical confusion in the Admin and SuperAdmin roles.
  3. We have created the develop-userTypeFix branch from the develop branch to fix this.
    1. All remedial work is being done on the develop-userTypeFix branch
    2. When the development work is complete on the develop-userTypeFix branch it will be merged back into develop
    3. This is planned to be completed shortly
  4. This issue was created to apply the desired functionality for the screen in this issue's title

This needs to be resolved as it is a showstopper bug.

Expected behavior

These conditions must apply:

  1. The userType must be applied per person per organization.
  2. Each SuperAdmin must be a SuperAdmin for all organizations
  3. All other userTypes would be on a per organization basis
  4. This has already been implemented in the develop-userTypeFix branch of Admin and the API. Your role will be to apply the change to the screen in this issue's title to the develop-userTypeFix code.
  5. The new functionality of userType must be unchanged.
  6. No other features must be affected
  7. All tests must be valid and pass

Screenshots

The current API schema:

image

The new API schema:

image

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  1. This is going to require someone with experience with the repo, or proven long term experience with typescript, MERN, and / or graphQL in their GitHub profile
  2. Research these issues for context with the new userType functionality:

Related issues:

  1. API: Fix the usage of userType talawa-api#1711
  2. Mobile: Fix the usage of userType talawa#2373
  3. Admin: Fix the usage of userType #1445
  4. Update the Organization People Screen Design and Functionality #1451
  5. Update the Community Users Screen Design and Functionality #1452
  6. Update adminApproved to expected functionality in the develop-userTypeFix branch talawa-api#1862
  7. Update thedevelop-userTypeFix branch with the latest features from develop - Fundraising / Recurring Events talawa-api#1904
  8. Admin: Fix the usage of userType #1445
  9. Fix the MemberDetail Screen in the develop-userTypeFix branch #1682
  10. Fix the OrganizationPeople Screen in the develop-userTypeFix branch #1683
  11. Fix the User/Users.tx Screen in the develop-userTypeFix branch #1684
  12. Fix the UserPortal/Organizations Screen in the develop-userTypeFix branch #1685
  13. Fix the UserPortal/Home.tsx Screen in the develop-userTypeFix branch #1686

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@its-VinayKumar
Copy link

@palisadoes Please assign me this issue.

@Cioppolo14
Copy link

@its-VinayKumar Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.
Also, this issue is going to require someone with experience with the repo, or proven long term experience with typescript, MERN, and / or graphQL in their GitHub profile.

@adi790uu
Copy link
Contributor

@palisadoes its Users/Users.tsx not UserPortal/Users.

@palisadoes palisadoes changed the title Fix the UserPortal/Users Screen in the develop-userTypeFix branch Fix the User/Users.tx Screen in the develop-userTypeFix branch Mar 10, 2024
@kanhaiya04
Copy link
Contributor

kanhaiya04 commented Mar 10, 2024

@Cioppolo14 Could you kindly assign me to this issue? I understand that I currently have two issues assigned to me, and I submitted a pull request for one last week, which is still in the review stage. I am requesting to be assigned to this particular issue because it is a prerequisite for my ongoing redesign of the user page.

As this issue remains unassigned, it is hindering progress on my current task.

I have been working on the users/users.tsx file for quite some time, I know how to fix this one very well.

@Cioppolo14
Copy link

@kanhaiya04 Yes, I will assign this to you for this particular exception.

@palisadoes palisadoes added the ui/ux issue related and being worked with the figma file of the Admin UI label Mar 24, 2024
@palisadoes palisadoes removed the ui/ux issue related and being worked with the figma file of the Admin UI label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants