Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation for formState.link as URL or String #1479

Closed
Keshav-0907 opened this issue Jan 22, 2024 · 7 comments
Closed

No validation for formState.link as URL or String #1479

Keshav-0907 opened this issue Jan 22, 2024 · 7 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@Keshav-0907
Copy link

Describe the bug
When creating a new advertisement, there is a missing validation check for the formState.link field. This allows users to input random strings or potentially invalid data.

To Reproduce
Steps to reproduce the behavior:

  1. Create an Organization
  2. Go to orgads/id=some_id.
  3. Click on Create new advertisement.
  4. Now you can eneter any random string in the Provide a link for content to be displayed input.

Expected behavior
The formState.link should undergo a validation to ensure that the provided input is a legitimate URL, preventing the submission of arbitrary or invalid strings.

Screenshots

420e2c94-da58-4f7b-9de8-e3c01d8d0e40.mp4
@Keshav-0907 Keshav-0907 added the bug Something isn't working label Jan 22, 2024
@github-actions github-actions bot added invalid This doesn't seem right unapproved labels Jan 23, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@palisadoes
Copy link
Contributor

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

This has been done 3 times.

@akhilender-bongirwar
Copy link
Contributor

I would like to work on this issue

@pushkar707
Copy link

Hi, I want to work over this issue

@Keshav-0907
Copy link
Author

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

This has been done 3 times.

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

This has been done 3 times.

Apologies for closing PRs without validation. I understand the impact on collaboration. I assure you it won't happen again. I appreciate your understanding. Thanks.

@ghost
Copy link

ghost commented Jan 27, 2024

Hi @palisadoes I want to contribute on this issue can you plz assign it to me.

Copy link

github-actions bot commented Feb 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants