-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No validation for formState.link as URL or String #1479
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community. This has been done 3 times. |
I would like to work on this issue |
Hi, I want to work over this issue |
Apologies for closing PRs without validation. I understand the impact on collaboration. I assure you it won't happen again. I appreciate your understanding. Thanks. |
Hi @palisadoes I want to contribute on this issue can you plz assign it to me. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Describe the bug
When creating a new advertisement, there is a missing validation check for the formState.link field. This allows users to input random strings or potentially invalid data.
To Reproduce
Steps to reproduce the behavior:
orgads/id=some_id
.Create new advertisement
.Provide a link for content to be displayed
input.Expected behavior
The formState.link should undergo a validation to ensure that the provided input is a legitimate URL, preventing the submission of arbitrary or invalid strings.
Screenshots
420e2c94-da58-4f7b-9de8-e3c01d8d0e40.mp4
The text was updated successfully, but these errors were encountered: