-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint git
Committed Files & PR Deltas / no-explicit-any
#1427
Comments
@palisadoes can i work on this ?? |
Please assign me @palisadoes |
Can i work on this? |
1 similar comment
Can i work on this? |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning due to no activity or PR. |
Hey, can I work on this issue? |
Should I follow similar approach to this for this issue in talawa-admin? |
Yes |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning due to inactivity |
I would like to work on this. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Reopening. It doesn't appear to be linting the deltas in the PR. Please verify and joint the discussion here. |
Closing. The issue was caused by something else |
We need the ability to selectively adjust our linting rules so that they are eventually applied to our entire code base.
.eslintrc.json
file.warn
toerror
then every file in the code base will be checked and we have frequently seen our tests fail for dozens of files in hundreds of lines of code.This is not acceptable.
We have been trying to more strictly lint the entire code base manually, but it has been very slow.
At the user CLI
We need a way to edit
.eslintrc.json
with increasingly stricter linting rules in such a way that the tests are only applied to the changed files with everygit commit
andgit push
command.These
git
commands must fail if the linting fails.With Every Pull Request
We are working on a Talawa-API pull request that checks each submitted file for linting compliance. This can be used as an example of how to run the test against individual files.
You must make sure that this functionality applied for all PRs for this repository whenever the
.eslintrc.json
file is updatedOther
Screenshots
When complete, you should be able to convert all these
.eslintrc.json
file lines containingwarn
oroff
toerror
and the tests will only be applied to the changed files ingit
The text was updated successfully, but these errors were encountered: