Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint git Committed Files & PR Deltas / no-explicit-any #1427

Closed
palisadoes opened this issue Jan 14, 2024 · 15 comments
Closed

Lint git Committed Files & PR Deltas / no-explicit-any #1427

palisadoes opened this issue Jan 14, 2024 · 15 comments
Assignees
Labels
feature request no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

We need the ability to selectively adjust our linting rules so that they are eventually applied to our entire code base.

  1. Linting rules are managed by the .eslintrc.json file.
  2. They are applied to the entire code base at once.
  3. If we change a rule from warn to error then every file in the code base will be checked and we have frequently seen our tests fail for dozens of files in hundreds of lines of code.

This is not acceptable.

We have been trying to more strictly lint the entire code base manually, but it has been very slow.

At the user CLI

We need a way to edit .eslintrc.json with increasingly stricter linting rules in such a way that the tests are only applied to the changed files with every git commit and git push command.

These git commands must fail if the linting fails.

With Every Pull Request

We are working on a Talawa-API pull request that checks each submitted file for linting compliance. This can be used as an example of how to run the test against individual files.

You must make sure that this functionality applied for all PRs for this repository whenever the .eslintrc.json file is updated

Other

  1. There may be ways to achieve the CLI goals by updating our existing Git Hooks
  2. Your solution should preferably work within coding environments such as VScode
  3. Please work with @EshaanAgg on this issue

Screenshots

When complete, you should be able to convert all these .eslintrc.json file lines containing warn or off to error and the tests will only be applied to the changed files in git

image

@AmitSharma512
Copy link

@palisadoes can i work on this ??

@skushagra9
Copy link

Please assign me @palisadoes

@Pranavx1
Copy link

Can i work on this?

1 similar comment
@Pranavx1
Copy link

Can i work on this?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 30, 2024
@Cioppolo14
Copy link

Unassigning due to no activity or PR.

@devsargam
Copy link

Hey, can I work on this issue?

@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Jan 30, 2024
@devsargam
Copy link

Should I follow similar approach to this for this issue in talawa-admin?
PalisadoesFoundation/talawa-api#1677 (comment)

@palisadoes
Copy link
Contributor Author

Yes

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 18, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 4, 2024
@lakshz
Copy link

lakshz commented Mar 5, 2024

I would like to work on this.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 16, 2024
@palisadoes
Copy link
Contributor Author

Reopening. It doesn't appear to be linting the deltas in the PR. Please verify and joint the discussion here.

@palisadoes
Copy link
Contributor Author

Closing. The issue was caused by something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request no-issue-activity No issue activity test Testing application
Projects
None yet
Development

No branches or pull requests

7 participants