Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified login and registration form component for admin portal and user portal #1424

Closed
aashimawadhwa opened this issue Jan 13, 2024 · 8 comments
Assignees

Comments

@aashimawadhwa
Copy link
Member

Is your feature request related to a problem? Please describe.
We aim to create a unified login and registration form component, tailoring its behavior through props for both user and admin login screens.

Describe the solution you'd like
make a single component and pass the required props

Additional context
NA

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@adi790uu
Copy link
Contributor

Hey I would like to solve this issue!

@AVtheking
Copy link

I would like to work on this issue

@nakul30
Copy link

nakul30 commented Jan 14, 2024

Is your feature request related to a problem? Please describe. We aim to create a unified login and registration form component, tailoring its behavior through props for both user and admin login screens.

Describe the solution you'd like make a single component and pass the required props

Additional context NA

Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

But these both are already present in the single component

@adi790uu
Copy link
Contributor

adi790uu commented Jan 23, 2024

Hey @aashimawadhwa @Cioppolo14 I have few questions?

1.what should be done about the tests for Login pages, should i keep the AdminLogin and UserLogin tests as separate files or make it such that it is a single file?

2.Should I delete the UserLogin folder as I have integrated the logic in Login.tsx file.

@aashimawadhwa
Copy link
Member Author

aashimawadhwa commented Jan 24, 2024

So go ahead like this,

  • make two seprate components user and admin and test file for each of them
  • finally make a login component and teat file for it and render admin and user login here.
    I hope this clears all your doubts. @adi790uu

@rishabhbizzle
Copy link

This issue is a duplicate of #1377 @aashimawadhwa which I've already fixed (check the video I had attached in the issue replies) and will be raising PR for it very shortly.

@aashimawadhwa
Copy link
Member Author

It's been 3 weeks for the issue what's the actual status? @rishabhbizzle

@aashimawadhwa
Copy link
Member Author

@Cioppolo14 we can close this issue as it is a duplicate one.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants