Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 (LTS) #1274

Closed
palisadoes opened this issue Dec 24, 2023 · 6 comments
Closed

Upgrade to Node 20 (LTS) #1274

palisadoes opened this issue Dec 24, 2023 · 6 comments
Labels
feature request test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 24, 2023

Is your feature request related to a problem? Please describe.

  1. We need to ensure that the app runs on an LTS version of Node.js
    1. https://nodejs.org/en/about/previous-releases
  2. The installation guide doesn't specify the required LTS version of Node.js to be used
  3. The application needs to be tested to make sure that it works with an LTS version of Node.js
  4. Our GitHub Actions need to be updated to specify the LTS version of Node.js to be used

Describe the solution you'd like

  1. Upgrade to Node 20 LTS
  2. Update the installation guide to specify this LTS version of Node.js to be used
  3. Update the installation or automated setup process to fail if the minimum LTS version isn't being used
    1. Create a Setup Script for the .env configuration file #1233
  4. Test the application to make sure that it works with this LTS version
  5. Our GitHub Actions need to be updated to specify this LTS version of Node.js to be used
  6. Address all warnings and errors (especially those related to deprecation) to the best of your ability according to industry best practice
  7. All existing tests must pass

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Veer0x1
Copy link

Veer0x1 commented Dec 24, 2023

would like to work on it

@Veer0x1
Copy link

Veer0x1 commented Dec 26, 2023

@palisadoes @Cioppolo14 in push workflow somewhere npm is used and somewhere yarn is used. Is it intentional??

Screenshot 2023-12-27 at 1 16 04 AM

@Veer0x1
Copy link

Veer0x1 commented Dec 26, 2023

And in push.yml file for node version we are using matrix strategy but it is not defined. So should change it to directly use the LTS version or create a matrix strategy??

Screenshot 2023-12-27 at 1 28 49 AM

@Veer0x1 Veer0x1 mentioned this issue Dec 27, 2023
@Veer0x1
Copy link

Veer0x1 commented Dec 28, 2023

Why isn't issues getting closed, when PR get merged?

@Veer0x1 Veer0x1 removed their assignment Dec 28, 2023
@palisadoes
Copy link
Contributor Author

  1. Don't remove yourself from assignment when the PR is completed and the issue isn't closed. It means we could assign the issue to someone else by accident
  2. The automatic closing seems to only work on the default branch. We sometimes forget to close the issue

@Veer0x1
Copy link

Veer0x1 commented Dec 28, 2023

Okay, I will take care of it from now onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request test Testing application
Projects
None yet
Development

No branches or pull requests

3 participants