Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated request library #1228

Closed
palisadoes opened this issue Dec 21, 2023 · 9 comments
Closed

Upgrade deprecated request library #1228

palisadoes opened this issue Dec 21, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 21, 2023

Describe the bug
When the command npm install --legacy-peer-deps is run for the first time as part of the installation process, this error message is seen.

npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142

To Reproduce

  • See above

Expected behavior

  1. No error message because the library has been updated, or suitably replaced, not because the error message has been suppressed.
  2. All tests pass and are updated for the new library
  3. If the package is no longer used, then it must be removed
  4. No application functionality is affected

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@palisadoes palisadoes added the bug Something isn't working label Dec 21, 2023
@palisadoes
Copy link
Contributor Author

@hharshas You have requested to be assigned to 10 issues in the space of 5 minutes. Everyone needs to get a chance to work on issues. Once you have been assigned two issues, the next person in line in the remaining 8 will be provided access. Please watch this video for guidance

Your actions are not in keeping with the spirit of the community. Please adjust your activities to be more collaborative.

@Cioppolo14 @noman2002 @Kevoniat please take note.

@Veer0x1
Copy link

Veer0x1 commented Dec 23, 2023

would like to work on this.

@Cioppolo14
Copy link

@Veer0x1 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@sarthak17jain
Copy link

I would love to work on this

Copy link

github-actions bot commented Jan 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 5, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 6, 2024
@NayOoLwin5
Copy link

I would like to work this issue

@NayOoLwin5
Copy link

NayOoLwin5 commented Jan 22, 2024

Hi @palisadoes, request package is dependency of jest-enzyme package which is the latest currently used.

[email protected] /Users/innolabs/talawa/talawa-admin
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        ├─┬ [email protected]
        │ ├─┬ [email protected]
        │ │ └── [email protected] deduped
        │ └── [email protected] deduped
        └── [email protected]

Is there anyway I can tackle this issue?

@palisadoes
Copy link
Contributor Author

If that is the case, we should close this issue.
Thanks for investigating this

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants