Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated request-promise-native library #1226

Closed
palisadoes opened this issue Dec 21, 2023 · 14 comments
Closed

Upgrade deprecated request-promise-native library #1226

palisadoes opened this issue Dec 21, 2023 · 14 comments
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 21, 2023

Describe the bug
When the command npm install --legacy-peer-deps is run for the first time as part of the installation process, this error message is seen.

npm WARN deprecated [email protected]: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142

To Reproduce

  • See above

Expected behavior

  1. No error message because the library has been updated, or suitably replaced, not because the error message has been suppressed.
  2. All tests pass and are updated for the new library
  3. If the package is no longer used, then it must be removed
  4. No application functionality is affected

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@palisadoes palisadoes added the bug Something isn't working label Dec 21, 2023
@palisadoes
Copy link
Contributor Author

@hharshas You have requested to be assigned to 10 issues in the space of 5 minutes. Everyone needs to get a chance to work on issues. Once you have been assigned two issues, the next person in line in the remaining 8 will be provided access. Please watch this video for guidance

Your actions are not in keeping with the spirit of the community. Please adjust your activities to be more collaborative.

@Cioppolo14 @noman2002 @Kevoniat please take note.

@hharshas
Copy link

@palisadoes would keep that in mind from now onwards

@sarthak17jain
Copy link

I would love to work on this

@Cioppolo14
Copy link

@sarthak17jain Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

Copy link

github-actions bot commented Jan 9, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 9, 2024
@Cioppolo14
Copy link

@sarthak17jain Are you working on this?

@varunsh17
Copy link

Would like to work upon the issue.

@Cioppolo14
Copy link

Unassigning due to inactivity.

@Cioppolo14 Cioppolo14 assigned varunsh17 and unassigned sarthak17jain Jan 9, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Jan 9, 2024
@varunsh17
Copy link

Screenshot 2024-01-09 235149

These are the dependencies request-promise-native depends and are being used currently.
After uninstalling it, I see no difference (The talawa-admin localhost works fine).
I wanna ask Why are we not removing this dependency ?

@palisadoes
Copy link
Contributor Author

Please read the issue's requirements

@varunsh17
Copy link

varunsh17 commented Jan 11, 2024

The Below mentioned lines indicate that request-promise-native library is still in use as it is indirectly use by other dependencies, our error is coming because of this. @palisadoes @Cioppolo14

Link1
Link2
Link3
Link4

@varunsh17
Copy link

varunsh17 commented Jan 18, 2024

@palisadoes @Cioppolo14
Should I consider removing those sub-dependencies too ? as I commented above that request-promise-native is still used by another packages internally..

@palisadoes
Copy link
Contributor Author

Upgrade dependencies to the best of your ability by only editing the package.json file

@varunsh17 varunsh17 removed their assignment Jan 21, 2024
@git-init-priyanshu
Copy link
Member

git-init-priyanshu commented Jan 27, 2024

I think we can close this issue now because the request-promise-native and left-pad libraries are both dependencies of the jest-enzyme library and my PR, #1501, removes the jest-enzyme library, thereby resolving both warnings.
Screenshot from 2024-01-27 10-05-28
Screenshot from 2024-01-27 10-05-48
After removing jest-enzyme library:
Screenshot from 2024-01-26 21-50-27

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants