Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated source-map-resolve library #1224

Closed
palisadoes opened this issue Dec 21, 2023 · 11 comments
Closed

Upgrade deprecated source-map-resolve library #1224

palisadoes opened this issue Dec 21, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 21, 2023

Describe the bug
When the command npm install --legacy-peer-deps is run for the first time as part of the installation process, this error message is seen.

npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated

To Reproduce

  • See above

Expected behavior

  1. No error message because the library has been updated, or suitably replaced, not because the error message has been suppressed.
  2. All tests pass and are updated for the new library
  3. If the package is no longer used, then it must be removed
  4. No application functionality is affected

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@palisadoes palisadoes added the bug Something isn't working label Dec 21, 2023
@hharshas
Copy link

i want to work on this issue

@palisadoes
Copy link
Contributor Author

@hharshas You have requested to be assigned to 10 issues in the space of 5 minutes. Everyone needs to get a chance to work on issues. Once you have been assigned two issues, the next person in line in the remaining 8 will be provided access. Please watch this video for guidance

Your actions are not in keeping with the spirit of the community. Please adjust your activities to be more collaborative.

@Cioppolo14 @noman2002 @Kevoniat please take note.

Copy link

github-actions bot commented Jan 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 1, 2024
@palisadoes
Copy link
Contributor Author

unassigning due to inactivity and no related PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 2, 2024
@Veer0x1
Copy link

Veer0x1 commented Jan 10, 2024

Can I take up this issue?

@NayOoLwin5
Copy link

I would like to work on it. Can I be assigned to this issue?

@Cioppolo14
Copy link

@Veer0x1 @NayOoLwin5 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@aarishshahmohsin
Copy link
Contributor

Can I be assigned this issue?

@aarishshahmohsin
Copy link
Contributor

@Cioppolo14

The package jest-enzyme was removed in the PR #1501 and with that the error message also disappeared. So there is no need of a PR on this issue.

The deprecated package that was causing the error message was jest-ezyme with version '7.1.2' due it being dependent on source-map-resolve. This package is an addition on jest used for react testing but it is not supported for React 17 and hence the package enzyme-adapter-react-17 is used.

However, the use of an enzyme adapter is a work around and not a concrete solution because now react testing is done with React Testing Library. Should I raise an issue for this?

@aarishshahmohsin
Copy link
Contributor

@palisadoes is there any update?

@palisadoes
Copy link
Contributor Author

OK. Open an issue for the best practice and remove all the unnecessary packages from the previous methodology.

Closing

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants