Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading react-router-dom from v5.2.0 to v6. #1210

Closed
git-init-priyanshu opened this issue Dec 17, 2023 · 5 comments
Closed

Upgrading react-router-dom from v5.2.0 to v6. #1210

git-init-priyanshu opened this issue Dec 17, 2023 · 5 comments

Comments

@git-init-priyanshu
Copy link
Member

Is your feature request related to a problem? Please describe.
Right now the talawa uses old version of react-router-dom ( v5.2.0 ).

Describe the solution you'd like
I want react-router-dom to upgrade to v6 ( newer version ) and to use createBrowserRouter.

Approach to be followed (optional)
Following this document: https://reactrouter.com/en/main/upgrading/v5

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@git-init-priyanshu
Copy link
Member Author

I would like to work on this issue.

@Cioppolo14
Copy link

@git-init-priyanshu Could you explain why you want to do this?

@noman2002 @aashimawadhwa Could I have your opinion on this?

@git-init-priyanshu
Copy link
Member Author

Right now react-router-dom works just fine and does not really need an update. I also want to know your thoughts on whether this is a valid issue or not.

@palisadoes
Copy link
Contributor

We are focusing on upgrades that are related to GitHub dependabot security updates or those that are necessary to fix a bug or create a meaningful feature that greatly improved the user experience.

Thanks for considering this, but we have bigger priorities.

Closing

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2023
@git-init-priyanshu
Copy link
Member Author

We are focusing on upgrades that are related to GitHub dependabot security updates or those that are necessary to fix a bug or create a meaningful feature that greatly improved the user experience.

Thanks for considering this, but we have bigger priorities.

Closing

Ok sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants