Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: When creating a new advertisement in the Advertisement section, our page refreshes unexpectedly. #1115

Closed
aialok opened this issue Dec 2, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@aialok
Copy link
Contributor

aialok commented Dec 2, 2023

Describe the bug

  • Bug Report: In the Advertisement Section, when creating a new advertisement, our page refreshes due to the use of window.location.reload().

To Reproduce
Steps to reproduce the behavior:

  1. Go To advertisement section
  2. Create a new advertisement

Expected behavior

  • After creating a new advertisement in the Advertisement Section, the page should remain static without any automatic refresh.

Actual behavior

  • Currently, upon creating a new advertisement, the page refreshes unexpectedly due to the use of window.location.reload().

Screenshots

  • Before
cinnamon-2023-12-02T215527+0530.webm
  • After
cinnamon-2023-12-02T223826+0530.webm

Additional details

  • Additonally I have fixed another bug as well. Previously, when creating a new advertisement, it did not appear in the advertisement section immediately; a page reload was required. Additionally, I have set setFormState to its initial state.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@aialok aialok added the bug Something isn't working label Dec 2, 2023
@aialok
Copy link
Contributor Author

aialok commented Dec 2, 2023

@palisadoes I would love to work on this issue please assign this to me.
Thank you : )

@SiddheshKukade
Copy link
Member

Hi, the reason it is not loading is because you're not filling up the dates. You can check on code that on those tabs I've used date logic to separate them.

@aialok
Copy link
Contributor Author

aialok commented Dec 5, 2023

Hi, the reason it is not loading is because you're not filling up the dates. You can check on code that on those tabs I've used date logic to separate them.

Hi @SiddheshKukade sir, Can you please be more specific about the comment I am not able to find? Or are you referring to the loading of advertisements when we create a new one? Please clarify.

@git-init-priyanshu
Copy link
Member

Hey @aialok are you still working on this?

@aialok
Copy link
Contributor Author

aialok commented Dec 10, 2023

Yes @indresh149 . I done with the code, I need to write some test case for the code I have changed.
Right now my end sem exams are going on that's why I am not creating a pull request.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 21, 2023
@palisadoes
Copy link
Contributor

Unassigning due to inactivity and no linked pull request

@hharshas
Copy link

I would like to do this

@aialok
Copy link
Contributor Author

aialok commented Dec 21, 2023

I am working on this issue, basically I have done with the code, but writing test cases creating some problem. I am working on issue. Will make a pull request by today.
And also my end semester exams was there.

@palisadoes
Copy link
Contributor

I am working on this issue, basically I have done with the code, but writing test cases creating some problem. I am working on issue. Will make a pull request by today. And also my end semester exams was there.

OK, I'll reassign it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants