Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PPSCI Export&Infer No.35】nowcastnet #895

Merged
merged 11 commits into from
May 21, 2024

Conversation

smallpoxscattered
Copy link
Contributor

@smallpoxscattered smallpoxscattered commented May 13, 2024

Copy link

paddle-bot bot commented May 13, 2024

Thanks for your contribution!

HydrogenSulfate

This comment was marked as spam.

examples/nowcastnet/nowcastnet.py Outdated Show resolved Hide resolved
examples/nowcastnet/nowcastnet.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拉一下最新的develop分支跟这个PR的分支合并一下。

@smallpoxscattered
Copy link
Contributor Author

拉一下最新的develop分支跟这个PR的分支合并一下。

好的好的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件与本PR无关,不需要更改

mkdocs.yml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件与本PR无关,不需要更改

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件与本PR无关,不需要更改

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件与本PR无关,不需要更改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊,这是我改的,我还以为是老师改的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊,这是我改的,我还以为是老师改的

这个PR我只帮忙改了dtype,其他文档没有改动

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也不知道咋回事,我再弄弄,抱歉了,老师

pretrained_model_path: https://paddle-org.bj.bcebos.com/paddlescience/models/nowcastnet/nowcastnet_pretrained.pdparams
export_path: ./inference/nowcastnet
pdmodel_path: ${INFER.export_path}.pdmodel
pdpiparams_path: ${INFER.export_path}.pdiparams
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段名称麻烦修改下

Suggested change
pdpiparams_path: ${INFER.export_path}.pdiparams
pdiparams_path: ${INFER.export_path}.pdiparams

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加 log_freq 字段,否则infer报错

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的好的

HydrogenSulfate

This comment was marked as outdated.

Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiminzhang0830 zhiminzhang0830 merged commit 9ce38b6 into PaddlePaddle:develop May 21, 2024
3 of 4 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* nowcastnet.py

* nowcastnet.py

* nowcastnet.py

* Update examples/nowcastnet/nowcastnet.py

Co-authored-by: HydrogenSulfate <[email protected]>

* Update examples/nowcastnet/nowcastnet.py

Co-authored-by: HydrogenSulfate <[email protected]>

* nowcastnet

* nowcastnet

---------

Co-authored-by: HydrogenSulfate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants