[Agent] Fix Singleton #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #212 +/- ##
===========================================
- Coverage 64.77% 64.74% -0.04%
===========================================
Files 57 57
Lines 2947 2947
===========================================
- Hits 1909 1908 -1
- Misses 1038 1039 +1 ☔ View full report in Codecov by Sentry. |
sijunhe
approved these changes
Dec 25, 2023
skyan
pushed a commit
to skyan/ERNIE-Bot-SDK
that referenced
this pull request
Dec 26, 2023
* Fix makefiles * Fix bugs * Enhance file_io * Update library code * Update examples * Update tests * Fix exceptions * Fix error info * Remove use of environment variables in integration tests * Fix protocol * Fix type hints * Fix * Fix typing * Fix style * Fix cleanup bugs * Fix data race * Fix bugs * Show file type * Fix bugs * Fix linting issues * Fix linting issues * Fix integration tests * Remove unused file * Fix and enhance * Fix style * Fix CI * Update CI config * Fix style * Remove anchors * Enhance mixins * Fix singleton * Fix typing * Fix code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 #193 中，为了规避元类实现的单例模式存在的问题（copy将导致多个实例同时存在），使用重写
__new__的方式实现了单例。但新的方式存在更严重的问题：尽管对象确实是单例，但__init__在每次实例化时调用，这直接导致GlobalFileManagerHandler类的行为异常。此PR修改回元类实现的单例，并记录该方法存在的问题，期望后续修复。