Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the Kaitai Struct specs better and send them to Kaitai Struct Formats if it makes any sense #39

Open
KOLANICH opened this issue Jan 1, 2021 · 0 comments
Open

Document the Kaitai Struct specs better and send them to Kaitai Struct Formats if it makes any sense #39

KOLANICH opened this issue Jan 1, 2021 · 0 comments

Comments

@KOLANICH
Copy link

KOLANICH commented Jan 1, 2021

Hi. I have noticed some ksy specs in your repository implementing messages of some protocol.

https://github.com/PacktPublishing/Deep-Reinforcement-Learning-Hands-On-Second-Edition/tree/master/Chapter16/ksy

Could you document them better?

Fill in the matadata block with all the needed metainfo (full title of the protocol, xrefs to its identifiers in other places, doc-refs to docs), write a short summary doc answering the following questions:

  • are they implementing something that is a de-facto standard or just has a widespread use in some area?
  • how can a sample blob be acquired (a link, or a script generating it)?

If it is something community can benefit from, could you send the specs to Kaitai Struct Formats repo?
@KOLANICH KOLANICH changed the title Better document the Kaitai Struct specs and send them to Kaitai Struct Formats if it makes any sense Document the Kaitai Struct specs better and send them to Kaitai Struct Formats if it makes any sense Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KOLANICH