From 58fac6a7ebab45302ee88dd7fdb50148cfe48c26 Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Wed, 27 Mar 2024 11:07:24 -0100
Subject: [PATCH] Revert "Formally return metadata from
 _populate_missing_properties"

This reverts commit 291579a09dc9d1264434e3252fa8fda8aa767183.
---
 Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm b/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm
index e87b545..1f56778 100644
--- a/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm
+++ b/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm
@@ -50,7 +50,7 @@ sub PlaceOrder2 {
 
     # If the config says we should use borrower properties for deliveryprofile values
     # use as many as we can, these should have come in the payload
-    my ($metadata, $metadata_deliveryprofile_error) = _populate_missing_properties(
+    my $metadata_deliveryprofile_error = _populate_missing_properties(
         $metadata,
         $config,
         $check_populated_delivery_profile,
@@ -364,7 +364,7 @@ sub _populate_missing_properties {
                 } else {
 
                     # Neither the borrower or the config have the required value, return for error handling
-                    return ( undef, $metadata_name );
+                    return $metadata_name;
                 }
             }
         } else {
@@ -375,11 +375,10 @@ sub _populate_missing_properties {
             } else {
 
                 # The config does not have the required value, return for error handling
-                return ( undef, $metadata_name );
+                return $metadata_name;
             }
         }
     }
-    return ( $metadata, undef );
 }
 
 sub _make_request {