From e7ba10c71dfb247c711ed2bf86f739015838c0be Mon Sep 17 00:00:00 2001
From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Date: Thu, 27 Jun 2024 11:13:38 +0100
Subject: [PATCH] ACQUI-42: Add cypress tests for the settings module

---
 src/components/Settings/ModuleSettings.vue    |   4 +-
 .../e2e/settings/ModulesEnabled_spec.js       | 131 ++++++++++++++++++
 tests/cypress/e2e/settings/Settings_spec.js   |  80 +++++++++++
 3 files changed, 213 insertions(+), 2 deletions(-)
 create mode 100644 tests/cypress/e2e/settings/ModulesEnabled_spec.js
 create mode 100644 tests/cypress/e2e/settings/Settings_spec.js

diff --git a/src/components/Settings/ModuleSettings.vue b/src/components/Settings/ModuleSettings.vue
index 3d85ac2..70072bc 100644
--- a/src/components/Settings/ModuleSettings.vue
+++ b/src/components/Settings/ModuleSettings.vue
@@ -1,9 +1,9 @@
 <template>
     <div v-if="initialized">
         <h1>{{ moduleTitle }} settings</h1>
-        <form @submit="onSubmit($event)" v-if="settingsRenderingData.length">
+        <form @submit="onSubmit($event)" v-if="settingsRenderingData.length" id="settingsForm">
             <fieldset class="rows">
-                <ol>
+                <ol id="settingsList">
                     <SettingFormElement
                         v-for="(item, key) in settingsRenderingData"
                         v-bind:key="key"
diff --git a/tests/cypress/e2e/settings/ModulesEnabled_spec.js b/tests/cypress/e2e/settings/ModulesEnabled_spec.js
new file mode 100644
index 0000000..52d0f7c
--- /dev/null
+++ b/tests/cypress/e2e/settings/ModulesEnabled_spec.js
@@ -0,0 +1,131 @@
+
+describe("modulesEnabled", () => {
+    beforeEach(() => {
+        cy.login();
+        cy.title().should("eq", "Koha staff interface");
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+    });
+
+    it("Should correctly show the modules in modulesEnabled settings", () => {
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.visit("/acquisitions/settings/general");
+        cy.get("#modulesEnabled").find(".vs__actions").click();
+        cy.get("#modulesEnabled").find("li").as("options");
+        cy.get("@options").should("have.length", 1);
+
+        cy.get("#modulesEnabled .vs__open-indicator").click();
+        cy.get("#modulesEnabled .vs__dropdown-menu li:first").should(
+            "have.text",
+            "Funds and ledgers"
+        );
+    })
+
+    it("Should show newly selected modules on the settings homepage", () => {
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.visit("/acquisitions/settings/general");
+        cy.get("#modulesEnabled .vs__search").type(
+            "Funds and ledgers" + "{enter}",
+            { force: true }
+        );
+
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "funds",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.get("#settingsForm > fieldset.action > input[type=submit]").click();
+
+        //Should navigate back to the settings homepage and show the new module
+        cy.get("h1").contains("Settings");
+        cy.get(".navPanesGrid").children().should("have.length", 4);
+        cy.get(".navPanesGrid > a:nth-child(3) > span").contains("Funds and ledgers");
+    })
+
+    it("Should show newly selected modules in the left hand menu", () => {
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.visit("/acquisitions/settings/general");
+        cy.get("#modulesEnabled .vs__search").type(
+            "Funds and ledgers" + "{enter}",
+            { force: true }
+        );
+
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "funds",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.get("#settingsForm > fieldset.action > input[type=submit]").click();
+
+        //Should navigate back to the settings homepage and include the new module in the left hand menu
+        cy.get("h1").contains("Settings");
+        cy.get("#navmenulist > h5").contains("Acquisitions");
+        cy.get("#navmenulist > ul").children().should("have.length", 3);
+        cy.get("#navmenulist > ul > li:nth-child(1) > span > a > span").contains("Funds and ledgers");
+        cy.get("#navmenulist > ul > li:nth-child(2) > span > a > span").contains("Tasks");
+        cy.get("#navmenulist > ul > li:nth-child(3) > span > a > span").contains("Settings");
+    })
+});
\ No newline at end of file
diff --git a/tests/cypress/e2e/settings/Settings_spec.js b/tests/cypress/e2e/settings/Settings_spec.js
new file mode 100644
index 0000000..9e7a9d3
--- /dev/null
+++ b/tests/cypress/e2e/settings/Settings_spec.js
@@ -0,0 +1,80 @@
+describe("Acquisitions settings", () => {
+    beforeEach(() => {
+        cy.login();
+        cy.title().should("eq", "Koha staff interface");
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+    });
+
+    it("Should load the settings homepage", () => {
+        cy.visit("/acquisitions/settings");
+        cy.get("h1").contains("Settings");
+    });
+
+    it("Should only show active modules and base modules", () => {
+        cy.visit("/acquisitions/settings");
+        cy.get(".navPanesGrid").children().should("have.length", 3);
+        cy.get(".navPanesGrid > a:nth-child(1) > span").contains("General");
+        cy.get(".navPanesGrid > a:nth-child(2) > span").contains("Task management");
+        cy.get(".navPanesGrid > a:nth-child(3) > span").contains("Manual");
+    })
+
+    it("Should show module settings in each Module", () => {
+        // We'll use the general module for testing
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+        cy.visit("/acquisitions/settings/general");
+        cy.get("h1").contains("General settings");
+        cy.get("#settingsList").children().should("have.length", 1);
+        cy.get("#settingsList > li:nth-child(1) > label").contains("modulesEnabled:");
+    })
+
+});
+
+describe("Acquisitions settings for a user with no settings permissions", () => {
+    beforeEach(() => {
+        cy.login('CPLmanage_budgets', 'Test1234');
+        cy.title().should("eq", "Koha staff interface");
+        cy.intercept(
+            "GET",
+            "/api/v1/contrib/acquire/settings",
+            [
+                {
+                    "explanation": "Select which modules you wish to use in the acquisitions portal",
+                    "options": "",
+                    "type": "multiple",
+                    "value": "",
+                    "variable": "modulesEnabled"
+                }
+            ]
+        );
+    });
+
+    it("Should only show the manual", () => {
+        cy.visit("/acquisitions/settings");
+        cy.get(".navPanesGrid").children().should("have.length", 1);
+        cy.get(".navPanesGrid > a:nth-child(1) > span").contains("Manual");
+    })
+})
\ No newline at end of file