From 42104e95d401b62c97ac4d32b74bc65438448182 Mon Sep 17 00:00:00 2001 From: Alexander Blanchard Date: Mon, 30 Sep 2024 13:19:24 +0100 Subject: [PATCH 1/2] feat: Remove edit button from grapes view as page Remove Edit button from grapes view as page as the editor can be accessed through the breadcrumbs. --- .../interface/themes/responsive/WebBuilder/grapesPage.tpl | 3 --- code/web/services/WebBuilder/GrapesPage.php | 7 ------- 2 files changed, 10 deletions(-) diff --git a/code/web/interface/themes/responsive/WebBuilder/grapesPage.tpl b/code/web/interface/themes/responsive/WebBuilder/grapesPage.tpl index 30d60d1f1a..2c42da706d 100644 --- a/code/web/interface/themes/responsive/WebBuilder/grapesPage.tpl +++ b/code/web/interface/themes/responsive/WebBuilder/grapesPage.tpl @@ -2,9 +2,6 @@ - {if $canEdit} -
- {/if} {$title|escape: 'html'} diff --git a/code/web/services/WebBuilder/GrapesPage.php b/code/web/services/WebBuilder/GrapesPage.php index aaae1e742a..1b6ff2a767 100644 --- a/code/web/services/WebBuilder/GrapesPage.php +++ b/code/web/services/WebBuilder/GrapesPage.php @@ -42,8 +42,6 @@ function launch() { $title = $this->grapesPage->title; $interface->assign('id', $this->grapesPage->id); $interface->assign('contents', $this->grapesPage->getFormattedContents()); - $editButton = $this->generateEditPageUrl(); - $interface->assign('editPageUrl', $editButton); $canEdit = UserAccount::userHasPermission( 'Administer All Grapes Pages', 'Administer Library Grapes Pages'); $interface->assign('canEdit', $canEdit); @@ -66,11 +64,6 @@ function canView(): bool { return true; } - function generateEditPageUrl() { - $objectId = $this->grapesPage->id; - $templatesSelect - $this->grapesPage->templatesSelect; - return '/services/WebBuilder/GrapesJSEditor?objectAction=edit&id=' . $objectId . '&tempalteId=' . $templatesSelect; - } function getBreadcrumbs(): array { $breadcrumbs = []; From 96774642c635a84f9902e4830a860e1493b32c54 Mon Sep 17 00:00:00 2001 From: Alexander Blanchard Date: Fri, 4 Oct 2024 16:55:40 +0100 Subject: [PATCH 2/2] chore: Update chcnage log --- code/web/release_notes/24.11.00.MD | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 code/web/release_notes/24.11.00.MD diff --git a/code/web/release_notes/24.11.00.MD b/code/web/release_notes/24.11.00.MD new file mode 100644 index 0000000000..31ddefe3e3 --- /dev/null +++ b/code/web/release_notes/24.11.00.MD @@ -0,0 +1,2 @@ +## Aspen Discovery Updates +- Remove edit button in admin view of Grapes JS Pages as breadcrumbs already allow users to navigate back to the editor and are in keeping with the rest of Aspen. (*AB*) \ No newline at end of file