forked from Aspen-Discovery/aspen-discovery
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.09.00 community engagement piece #113
Closed
AlexanderBlanchardAC
wants to merge
196
commits into
PTFS-Europe:24.09.00
from
AlexanderBlanchardAC:24.09.00_community_engagement_piece
Closed
24.09.00 community engagement piece #113
AlexanderBlanchardAC
wants to merge
196
commits into
PTFS-Europe:24.09.00
from
AlexanderBlanchardAC:24.09.00_community_engagement_piece
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs directory was getting wrong ownership, moving the logs directory ownership command to after the permission changes for the parent should fix it to test: run updateSitePermissions.sh <sitename>, observe that the permissions for var/log/aspen-discovery/<site>/logs are www-data:aspen_apache apply this patch run updateSitePermissions.sh <sitename>, observer that the permissions for /var/log/aspen-dsicovery/<site>/logs are now aspen:aspen
Functionality for custom self registration forms and ILS-based self registration via Sierra APIs for Sierra libraries Added TOS functionality for CarlX self registration via ILS Added release notes & DB updates
Sierra Self Reg
- Fixes dumb SQL mistake in whole-grade report - Improves record sort order with feedback from KW. Whole-grade report now sorts by student name. Whole-school report now sorts by grade, then student name.
Fix error when using RENAME COLUMN by using CHANGE COLUMN instead
temporary bandaid due to bugs with the setting not playing well with consortia
Fetching ILS Messaging fixes
temp disable cron function
Use CHANGE instead of RENAME
This sets up the CSV file and triggers its download. It will contain the column headers of the raw data table. The part setting up the output to the browser is directly based on the build CSV function in sys/UserLists/UserList.php, and only the filename has been changed. The CSV is populated with as many rows of data as found within the raw usage data table.
The branch name improperly extracted, leading to $branchList[$branchName]->showInSearchFacet systematically evaluated to false for scopes where the length of the scope code was not 4. All locations for that scope would be filtered out, resulting in empty facets which would therefore not be rendered. This fix replaces the hardcoded offset in the substr() method by the length of the scope + 1 to account for the #, allowing for proper branch name extraction, and appropriate filtering.
…cet_location_filter fix: extract branch name
…_for_existing_usage_graphs Data download for existing usage graphs
In Koha, it is possible to create item groups (i.e. volumes) without attaching items to that group. If an item group has no items, the volume level hold will be unfillable unless items are added to it at a future time. For these reasons, it makes sense to filter these empty volumes out. A possible future enhancement would be to make the display of empty volumes configurable. Test Plan: 1) Set up an instance of Koha connected to Aspen Discovery 2) Create 10 items, and four item groups on one record 3) Attach 3 items to each of 3 of the item groups 4) Run koha_export.jar 5) Note the empty volume shows in the list of volumes you can place holds on 6) Check out this branch 7) Recompile koha_export.jar 8) Repeat step 4 8) Note the empty volume is no longer in the volume pulldown Closes Aspen-Discovery#1989
Any libraries using the pre-release version of Koha's item groups ( i.e. volumes ) has since been upgraded past 22.11. This code should be safe to remove now as it relates to a version of a feature that was never part of community Koha. Test Plan: No changes in behavior should be noted Closes Aspen-Discovery#1990
…ic-Library/aspen-discovery into Nashville-Public-Library-24.09.00-smallFix
…-Public-Library/aspen-discovery into Nashville-Public-Library-24.09.00-PrintBarcodes
Get volume info for holds from MARC record when there is no volumes.txt for Symphony
…/24.09.00-QA Correct regexp for spaces-not-tabs detection
Account for patron types being '0' when doing boolean check to get the patron type object (common for Sierra libraries) This issue was made apparent when attempting to enable materials requests for patrons of this type Tested on my local To Test: Create a patron type 0 Enable materials requests for patrons of that type Check to see if materials requests are available via masquerade for a patron of that type
- If Lexis Nexis is used, the linking url will use /title instead of /media To Test: If using Lexis Nexis, links to those records will have an appended /title instead of the usual appended /media - Add patron code to variables used for Sierra self registration via Aspen To test: For a Sierra library, make sure the proper patron code is filled in, in self registration forms -> patron code Register a new test patron Check in Sierra that patron was registered with the correct type Updated release notes and tested on my local
Add ticket number
Get Patron Type Object Check
0e1e8bf
to
6abf9da
Compare
Community added to modules and campaign and milestones listed as actions.
Create Objects and DB tables for community campaigns and milestones. feat: Add campaigns to services Add campaigns to services so campaigns can now be added and edited by users with the correct permissions. feat: Add Milestones to services Add Milestones to services so users with the correct permissions can add and edit them. interim commit Interim commit Interim Commit
Add a My Campaigns section to the user account feat: Add Your Campaigns to Account feat: Alter display in My Campaigns
interim commit
feat: Enable Dashboards To Display Campaign Data feat: Milesone Progress displayed Progress per milestone displayed - using hardcoded completed milestone goal info.
Add if statement so community module only shows in admin list if enabled.
6abf9da
to
8f7fab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.