Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to have parent_aoi and sub_aois on AOI model #2

Closed
jkeifer opened this issue Aug 10, 2015 · 2 comments
Closed

Need to have parent_aoi and sub_aois on AOI model #2

jkeifer opened this issue Aug 10, 2015 · 2 comments

Comments

@jkeifer
Copy link
Member

jkeifer commented Aug 10, 2015

This issue references PSU-CSAR/vb-bagis-h#4. We need a relation on the AOI model to itself to allow parent-child relationships. The REST API should return a list of all the children of a parent, preferably with the ID and name.

RESTful practices probably prefers a hyperlink rather than an ID or name string, but the AOI URLs only have the ID in them; can the AOI URL have both ID and name, and be parseable by the desktop bagis?

@jkeifer
Copy link
Member Author

jkeifer commented Aug 28, 2015

One request in the referenced issue is to return an AOI ID of a parent AOI before the import task finishes, so child uploads can be started. Converting the model IDs to UUIDs (issue #7) allows pre-generating the AOI ID when the upload starts with very little risk of collisions. Thus, any upload response can contain the ID of the object to be imported, even the first time it returns--before the upload is even completed.

I am splitting the required work for this aspect of the request into a new ticket #11.

@jkeifer
Copy link
Member Author

jkeifer commented Oct 25, 2015

For my reference, it turns out this is only half completed. The fields exist on the AOI, but the create view method is provided by the generic UploadMixin. Thus, it does not call the new_upload view method with the appropriate arguments to actually set the parent_object_id on the upload that gets created. Additionally, the AOI create_from_upload and create methods have not been updated to include the the necessary arguments either.

The work is otherwise there, so cleaning these couple remaining issues up should implement this feature.

@jkeifer jkeifer added this to the Deploy revisions milestone Oct 26, 2015
@jkeifer jkeifer closed this as completed in a47833b Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant