Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle task to run the setup #7

Merged
merged 4 commits into from
Dec 6, 2016

Conversation

tasomaniac
Copy link
Contributor

Thanks for the great project.

I was actually doing a very similar project myself but I didn't figure out the permission so I thought I wasted my time and gave up the project.

I started using this one and it works great.

I thought I can improve the setup though. Here I've added a custom gradle task to do the setup automatically.

Here is my terminal:
image

Here is how it looks like on the device.
setup

@davidschreiber
Copy link
Contributor

Thank you for the contribution – I very much appreciate that! 👍 I'm going to check it out in detail later.

One thing I noticed, please add the changes to the setup guide HTML also to the original markdown file: https://github.com/PSPDFKit-labs/QuickDemo/blob/master/setup-guide.md

I manually generated that HTML from the markdown file. At some point it makes sense to automate this process, so it's more stable. I've created a follow-up issue for that: #8

@davidschreiber
Copy link
Contributor

Besides the above mentioned changes to the Markdown, this LGTM 💯

@tasomaniac
Copy link
Contributor Author

The setup-guide is updated. 👍

You may re-generate the html after you merge the PR but I think they should be almost the same.

@davidschreiber davidschreiber merged commit dfa9b45 into PSPDFKit-labs:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants