forked from ibm-power-utilities/powerpc-utils
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Changelog
2730 lines (1915 loc) · 105 KB
/
Changelog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
powerpc-utils-1.3.6
=====================================================================
commit 1d4147370a148b3a2ebadcf02abd4a6c9a763e6d
Author: Sourabh Jain <[email protected]>
Date: Sat Apr 27 10:18:32 2019 +0530
lparstat: add an option to print the lparstat report similar to legacy lparstat tool
This patch adds a new command line option (-l, --legacy) to allow
users to print the report similar to legacy lprastat tool without
affecting existing report format.
Changes done to make the current report format similar to legacy
report format are listed below:
1) The memory attribute will be printed in MB instead of KB.
2) cpus attribute will be referred as psize in legacy report format
and only printed in shared lpar environment.
3) On legacy lparstat tool the lcpu attribute is a combination of
two attributes, smt and number of online processor. Formula used
to calculate the lcpu is given below.
lcpu = smt * number of online processors
Signed-off-by: Sourabh Jain <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit dd6da6b329bac2743d1c80b5556b494c923c11ad
Author: Michael Bringmann <[email protected]>
Date: Mon Apr 29 11:25:18 2019 -0500
scripts: Improve handling of errors from subsidiary scripts
This patch is to fix the handling of errors by 'lsdevinfo' from
invocations of 'ofpathname' that also encounter errors. Error
messages from 'ofpathname' were being sent through 'stdout', and
interpreted as valid data by a number of script instructions in
'lsdevinfo'. Following is an example of such a failure when the
error results were forwarded to an associated HMC.
2019-02-19 22:05:38.212 [TID-5f68--72195] VIOS_CACHE: CacheVios.<-> saveCacheData 3*9080-M9S*130A068 cmd=lsdevinfo -c -q physloc=U78CD.001.FZH0128-P1-C1-T3-S4 -F status
2019-02-19 22:05:38.212 [TID-5f68--72195] RMC_VIOS: PIRmcViosClient.stdErr=/bin/ls: cannot access /sys/class/net/ofpathname:: No such file or directory
/bin/ls: cannot access Could: No such file or directory
/bin/ls: cannot access not: No such file or directory
/bin/ls: cannot access retrieve: No such file or directory
/bin/ls: cannot access logical: No such file or directory
/bin/ls: cannot access device: No such file or directory
/bin/ls: cannot access name: No such file or directory
/bin/ls: cannot access for: No such file or directory
/bin/ls: cannot access Open: No such file or directory
/bin/ls: cannot access Firmware: No such file or directory
/bin/ls: cannot access path: No such file or directory
/bin/ls: cannot access "/pci@800000029008004/ethernet@0"./device/driver: No such file or directory
This patch makes the following changes:
* Redirects the error messages from 'ofpathname' to stderr
* Adds more checks to 'lsdevinfo' to filter out stderr text
from input to various parsing commands.
Signed-off-by: Michael Bringmann <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 8b7978b114e5df89218daa9b4b48cc0e918ba917
Author: Sourabh Jain <[email protected]>
Date: Mon Feb 4 16:15:14 2019 +0530
lparstat: introduce the help command line option to print lparstat usage
This patch adds a function to print the usage of lparstat. Also,
a new element is added to structure option to handle long command
line argument for help.
Signed-off-by: Sourabh Jain <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit bc928b06605371b72c7fe8ec7e81886114a9e9d4
Author: Sourabh Jain <[email protected]>
Date: Thu Jan 31 14:25:21 2019 +0530
lparstat: restrict the physc and entc attribute values to two decimal places
Print format of physical processors consumed (physc) and percentage of
the entitled capacity consumed (entc) attributes has changed from six
decimal places to two.
The least possible value allowed for processor entitlement to a LPAR
is 0.05 so printing physc and entc values with such a high precision
is incorrect.
Signed-off-by: Sourabh Jain <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit b5fea40ac98d1c9a685d98c011e88180c31ca0be
Author: Vasant Hegde <[email protected]>
Date: Wed Feb 20 15:44:17 2019 +0530
man/update_flash: Add details to extract rpm format image
Signed-off-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit f567bdb8b2a3effdb4af06e2cf935b0350f2f881
Author: Vasant Hegde <[email protected]>
Date: Wed Feb 20 15:44:09 2019 +0530
man/update_flash: Fix man page
Add heading to NOTES section.
Signed-off-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
powerpc-utils-1.3.6
=====================================================================
commit 01c9cbcf4face809cb6953bc3cd2a30cd075ed16
Author: Tyrel Datwyler <[email protected]>
Date: Thu Dec 6 17:30:38 2018 -0600
lparstat: correct calculation of physc to use tbr
Currently phsyc is calculated using the sampled PURR values from lparcfg and
a derived timebase that lparstat itself calculates. However, both the Timer
Facilities section in Book III of the ISA and PAPR outline that this resource
calcuation is done by computing the ratio of the PURR delta and the Timebase
Register delta for the sampled period.
I've sent a patch upstream to the kernel list to also export the Timebase
Register (tbr) in /proc/ppc64/lparcfg [1]. Use this value for calculating
physc value when running on a kernel that exposes tbr.
[1] https://patchwork.ozlabs.org/patch/1009906/
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 7be598c7ffdf1f934e43af88a42e8b1e6391f91e
Author: Aravinda Prasad <[email protected]>
Date: Thu Dec 6 16:21:10 2018 +0530
lparstat: Enable desired and maximum memory stats
This patch enables the display of desired memory
and maximum memory stats with lparstat -i flag.
The value for these stats are already available
in /proc/powerpc/lparcfg file.
v2: updated man pages.
Signed-off-by: Aravinda Prasad <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit d1576f88dcc7008bcd3448172caff1b928be1254
Author: Aravinda Prasad <[email protected]>
Date: Thu Sep 6 15:01:04 2018 +0530
lparstat: Show available physical processors in the shared pool
This patch adds the "app" field that displays the available
processors in the shared pool.
The platform provides the summation of the physical processor
pool idle cycles through H_PIC hypercall. This data is updated
in the "pool_idle_time" field of the /proc/ppc64/lparcfg file.
This patch derives the "app" from the "pool_idle_time" field.
v2: Handle fgets() errors
Signed-off-by: Aravinda Prasad <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit fac783d18d61af232b957af259a15ed231f6869b
Author: Juliet Kim <[email protected]>
Date: Thu Sep 13 15:57:42 2018 -0400
ppc64_cpu: Limit number of CPUs for frequency calculation
The patch limits the number of threads used for CPU frequency calculation
to the minimum of either the actual number of CPUs in the system or
CPU_SETSIZE(currently 1024). In other words, if the number of CPUs in the
system is less than CPU_SETSIZE, a thread is created for each of the CPUs,
otherwise only CPU_SETSIZE threads are created. This is being done because
sched_setaffinity() will only work on CPU_SETSIZE CPUs, anything over the
limit is not supported.
Signed-off-by: Juliet Kim <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 3ce17a36d10bc09a49af9d56ceadad09708b46f1
Author: Nathan Fontenot <[email protected]>
Date: Thu Jul 19 23:12:40 2018 -0500
lsslot: Add ibm,dynamic-memory-v2 parsing capability
In order to support reporting memory LMB information the lsslot
command needs to know how to parse the ibm,dynamic-memory-v2
property. This patch adds this support to the shared
drslot_chrp_mem.c file.
In order to prevent the drmgr command from parsing this v2 property
a new flag is introduce, is_lsslot_cmd. The reason for this is that
we do not support memory DLPAR for ibm,dynamic-memory-v2 from
userspace.
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 6a1b89bb7e9f58262da0f08906674cae3efc7bfc
Author: Nathan Fontenot <[email protected]>
Date: Thu Jul 19 23:12:34 2018 -0500
lsslot: Split dynamic-memory v1 parsing into separate routine
In preparation for support of parsing the new ibm,dynamic-memory-v2
device tree property, this patch splits the current code that
parses the current v1 version of the device tree propertry into
its own routine.
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit c3f583a9f62ee33080523c2d1d076fdf8d5520e7
Author: Mamatha Inamdar <[email protected]>
Date: Tue Jul 17 21:24:31 2018 +0530
Patch to display logical name using bootlist -o option
Problem:
System unable to boot when OF device path name's set using -r option
EX: # bootlist -m normal -r /vdevice/v-scsi@30000010/disk@8100000000000000
Solution:
This patch is to set respective Open firmware device path names(-r)
and logical device path names(-o) using bootlist
Test Results:
Without patch:
# bootlist -m normal -r /vdevice/v-scsi@30000010/disk@8100000000000000
sda
# bootlist -m normal -r
sda
# bootlist -m normal -o
Could not translate sda to logical device name
With patch:
# ./bootlist -m normal -r /vdevice/v-scsi@30000010/disk@8100000000000000
/vdevice/v-scsi@30000010/disk@8100000000000000
# ./bootlist -m normal -r
/vdevice/v-scsi@30000010/disk@8100000000000000
# ./bootlist -m normal -o
sda
# ./bootlist -m normal -r sda
/vdevice/v-scsi@30000010/disk@8100000000000000
# ./bootlist -m normal -r
/vdevice/v-scsi@30000010/disk@8100000000000000
# ./bootlist -m normal -o
sda
Signed-off-by: Mamatha Inamdar <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
powerpc-utils-1.3.5
=====================================================================
commit 35d01313b5d03069bf8cabbcdfe39944da4ae65c
Author: Tyrel Datwyler <[email protected]>
Date: Thu Jun 14 16:08:50 2018 -0700
lsslot: add DRC Type description strings for new U.2 PCIe slots
Two new PCI slot types can be reported from firmware in the DRC Type
property for a PCI device. The following are the slot descriptions for
DRC types 43 and 44.
43 A U.2 PCI Express Rev 3 4x lane slot with 4x lanes connected
44 A U.2 PCI Express Rev 4 4x lane slot with 4x lanes connected
Currently, the lsslot utility reports "Unknown" for the description of
these pci devices. Update the php_slot_type_msg[] with these new slot
descriptions so that lsslot correctly reports them.
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 02249d0ce03ae6b06ca5dac47a53bdeb8986ac81
Author: John Allen <[email protected]>
Date: Thu Mar 15 11:12:05 2018 -0500
lsslot: Remove extra call to free_lmbs in failure cases
This reverts commit e6f476d32c33f5b8e364f930c467785495eeb0ce.
From my inspection, get_lmbs frees the lmb_list correctly in all failure
cases. The extra call to free_lmbs will cause the lmb_list to be freed
twice. I think it's likely that the original coverity issue that this was
meant to address was a false positive. Reverting the change has been seen
to resolve a seg fault.
Signed-off-by: John Allen <[email protected]>
Reviewed-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 05bb057b8953d536a952ff86eea3b0afeeefb377
Author: Tyrel Datwyler <[email protected]>
Date: Thu Feb 15 15:35:20 2018 -0800
ibmvscsis: remove deprecated ibmvscsis scripts and docs
The original ibmvscsis module was removed from the kernel a long time
ago, and has since been replaced with a new LIO implementation. The
documentation and administration scripts supplied in this package as
such have been deprecated. Lets go ahead and remove them.
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 9d86e33b7605e25473ea0a11d22a300274c8169b
Author: Tyrel Datwyler <[email protected]>
Date: Mon Jan 22 17:50:23 2018 -0600
Test for librtas/librtasevent headers and libraries
The current configure script only tests for the presence of librtas.h. Certain
distros have chosen to split the librtas package into seperate librtas and
librtasevent library/development packages. As a result compilation will fail
for the rtas_event_decode utility if librtasevent.h is missing.
Fix this by also checking for librtasevent.h, and for sanity purposes that
the libraries themselves are actually present and linkable.
Reported-by: Anton Blanchard <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 7790c5ae7ff50785c26e7d3942e0b86c9edb9df2
Author: Vasant Hegde <[email protected]>
Date: Sun Jan 21 21:10:08 2018 +0530
update_flash: Use device tree to get firmware version details
On P9, OPAL exports firmware information via device tree
(/ibm,firmware-versions node). Even recent hostboot firmware on P8 BMC system
exports these information via mini device tree.
Lets add support to parse device tree to get firmware information. If firmware
information is not present in device tree then fall back to existing ipmi
method.
Signed-off-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 081e7ac9675b49346e937236f38822b33c8c751b
Author: Vasant Hegde <[email protected]>
Date: Sun Jan 21 21:10:07 2018 +0530
update_flash: Use inband ipmi path to get firmware version
update_flash_nv uses 'ipmitool -I usb' interface to get firmware version
details. This is AMI BMC OEM feature and not available on other BMC systems.
Hence lets use inband interface to get firmware version details.
Signed-off-by: Vasant Hegde <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 73d847367d1a136d8e83d48e7ca4ff4602c0f5c7
Author: Michal Suchanek <[email protected]>
Date: Thu Jan 18 15:38:00 2018 -0800
drmgr: load rpadlpar_io on -C as well
Users do drmgr -C to verify their system.
However, -C does not select any hotplug type, and the rpadlpar_io kernel
module is loaded only when hotplug type pci, phb or slot is selected.
Make display_capabilities global and check it in check_kmods()
Signed-off-by: Michal Suchanek <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 7fb22cb5b8a0c95821024aa84750945134303f20
Author: John Allen <[email protected]>
Date: Wed Dec 6 10:33:59 2017 -0600
lparstat: Fix parsing of /proc/interrupts SPU line
The current means of parsing the SPU line in /proc/interrupts is incorrect.
Adding 11 to the current pointer is only correct if the number of SPU
interrupts in each column is a single digit. Otherwise, for values with
more than a single digit, we will only see the last digit of the value.
This patch fixes the issue by using strstr to check for the SPU line and
strtok to split the line into tokens in order to omit the arbitrary
whitespace between values.
Signed-off-by: John Allen <[email protected]>
Reported-by: Flos Lonicerae <[email protected]>
Reviewed-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 3dcc222814ec1d661710eda320aced13566817f2
Author: Tyrel Datwyler <[email protected]>
Date: Fri Jan 5 13:00:31 2018 -0800
lsdevinfo: fixup more null byte command substitution warnings
As was pointed out in commit 4fcc611a09ca ("warning: command
substitution: ignored null byte in input device") newer versions of Bash
(bash 4.4) warn about null byte in command substitutions. While that
commit fixed serveral instance by replacing the "cat" command with "tr"
it missed two other instances in the lsdevinfo script where cat was
being used to grab the "ibm,loc-code" property for a device.
This patch fixes the other two instances for virtual fibre channel
devices and pci ethernet devices.
fixes: 4fcc611a09ca ("warning: command substitution: ignored null byte in input device")
Cc: Seeteena Thoufeek <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 1f79078c979555a58a72326a318d956eb4efe4b5
Author: Tyrel Datwyler <[email protected]>
Date: Mon Dec 4 12:34:26 2017 -0800
Add mailing list address to README
Its been pointed out that the development mailing list address is not
listed in the README file, and that a google search still points to our
old sourceforge list.
Update the README with our current development mailing list.
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 149c7022a56e0ffb5fe27681f574d46860323e3c
Author: Anton Blanchard <[email protected]>
Date: Sun Oct 8 21:49:17 2017 -0700
ppc64_cpu: Scale CPU cycles counter by amount of time it ran
At the moment we start a CPU cycles counter, sleep one second and
read the counter value, assuming we got one second of time on the
PMU.
There are two issues with this. If someone else is consuming all
the available PMCs, we may end up context switching the PMC and
count for half (or less) of the time. In this case we report a CPU
frequency that is half (or less) of what it should be.
On the other hand if the sleep goes for longer than one second which
might happen on a busy box, then we count for too long and report a
CPU frequency that is too high.
Also check that we got a reasonable number of cycles and report
an error if we did not.
Signed-off-by: Anton Blanchard <[email protected]>
commit 8f9cd40fbcdda9d2447a1e51ed5dee2cb5c44542
Author: Harish <[email protected]>
Date: Fri Sep 29 10:34:44 2017 +0530
bootlist: Handle --help option
This patch handles --help option for bootlist command and returns
with 0
Signed-off-by: Harish <[email protected]>
[tyreld: reword patch subject line]
Signed-off-by: Tyrel Datwyler <[email protected]>
powerpc-utils-1.3.4
=====================================================================
commit c8083fbc1bfe1548057478ae46543bf58bffc7d4
Author: Michael Bringmann <[email protected]>
Date: Wed Aug 23 09:06:45 2017 -0500
powerpc-utils.spec: Add "Vendor: IBM Corp."
Ensure that "Vendor: IBM Corp." appears in archive for all checkouts
and derived builds.
Signed-off-by: Michael Bringmann <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 50f11c6c6618e7d59232d67e7446d07714af453b
Author: Nathan Fontenot <[email protected]>
Date: Thu Jul 6 12:31:36 2017 -0400
lsslot: Validate DRC property groups
Recently seen on a kvm guest running on a PowerNV system, the
lsslot command segfaulted when trying to free the drc information.
# gdb -q ./lsslot
Reading symbols from ./lsslot...done.
(gdb) run -c memory
Starting program: ./lsslot -c memory
Program received signal SIGSEGV, Segmentation fault.
free_drc_info () at src/drmgr/common_ofdt.c:287
287 all_drc_lists = list->all_next;
The root cause of this is that the DRC properties in the guest were empty.
This caused the lsslot (and likely possible in drmgr since this code
is common to both commands) to improperly parse the device tree
information.
To fix this we need to add a check after gathering information for
each of the DRC properties when reading DRC property group data. If
there are no entries in any of the DRC properties we cannot continue.
Reported-by: Seeteena Thoufeek <[email protected]>
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit c25ae395db914f1137bb8a718277ea4b6f69136b
Author: Samuel Mendoza-Jonas <[email protected]>
Date: Mon Jul 10 11:23:27 2017 +1000
ppc64_cpu: Treat CPUs as online if cpu hotplug not enabled
cpu_online() looks for the "online" attribute to decide if a cpu is
online, however if the kernel does not have CONFIG_HOTPLUG_CPU enabled
the attribute will not exist.
get_attribute() calls access() first to check if the attribute exists,
which will set errno with ENOENT if it is missing. If get_attribute()
fails with this specific error, treat the cpu as online.
Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
[tyreld: removed unnecessary braces from if block]
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 817900edd96c66d6f43f75aaefbe38bba6bab035
Author: Tyrel Datwyler <[email protected]>
Date: Fri Aug 4 16:24:01 2017 -0700
Revert "ppc64_cpu: Treat CPUs as online if cpu hotplug not enabled"
This reverts commit 5f70f6c1af2dd61122acfdbaa6e38be062bb220a.
Reverting the commit as further inspection came to show it actually
marked a cpu as offline when hotplug was not enabled.
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 136fab970076018bd56aa1aa0c09b8954b89b0b5
Author: Nathan Fontenot <[email protected]>
Date: Tue Jun 6 12:12:36 2017 -0400
drmgr: Correct some bad formatting in drmig_chrp_pmig.c
No functional changes, justy making the code more readable.
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 1c5319c76ae8b378bfd59e8c0a08e89f83867dbf
Author: Nathan Fontenot <[email protected]>
Date: Wed Jun 7 16:35:33 2017 -0400
drmgr: Correct errno usage in init_cpu_info()
The error message reported if allocaing a dr node fails
should not report the errno value. The call to allocate the
dr node makes multiple syscalls and there is no way to
determine which one last updated errno.
Signed-off-by: Nathan Fontenot <[email protected]>
Reviewed-by: Paul Clarke <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 998933a5185f9c56d1d6bce77301f3e7be6a54cf
Author: Nathan Fontenot <[email protected]>
Date: Wed Jun 7 16:35:28 2017 -0400
drmgr: Correct errno usage use in validate_paltform()
For validate_platform(), the call to get_property makes many
system calls and there is no way to know what last updated the
errno value. This patch drops the output of strerror() due to
this reason.
Signed-off-by: Nathan Fontenot <[email protected]>
Reviewed-by: Paul Clarke <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit d1c6662d38adeb98a1fd8906cd54031c6fdd653d
Author: Nathan Fontenot <[email protected]>
Date: Wed Jun 7 16:35:22 2017 -0400
drmgr: Stale errno usage corrections
Several places in the drmgr code use a stale value of errno either
as a return code or when printing an error message. A common example
of this is calling the say() routine and then returning the value of
errno. The say() routine makes several system calls and the value of
errno after a call to say() no longer reflects the original errno
value.
Several places in the drmgr code were updated to properly handle
the return codes from functions such as write() or open() where we
should be checking for rc == -1 instead of rc <= 0. This does make
a difference as errno won't be set for rc == 0.
Note that partial write return codes are not really handled in the
drmgr code. The drmgr command is writing to sysfs and /proc
files where we know that they will either return success or
failure and set errno, no partial writes.
Signed-off-by: Nathan Fontenot <[email protected]>
Reviewed-by: Paul Clarke <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 479f1a1122f7d9025d3a21e60a0431d2eba6ee2f
Author: Nathan Fontenot <[email protected]>
Date: Tue Jun 6 12:12:22 2017 -0400
drmgr: Correct drc type checking in check_kmods()
Fixes: f9986ac43011 ("drmgr: Move options.ctype to global usr_drc_type")
When the conversion to using the global usr_drc_type was
made the logic checking for whic drc types we need to check
the rpadlpar_io kernbel module for was broken. This corrects
the check.
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 27e8d5b8218bc8c8c772080b0d99691bd31d4f0f
Author: Chandni Verma <[email protected]>
Date: Thu Jun 1 19:07:13 2017 +0530
lsslot: Rectify usr_drc_name check
This incorrect check refrains lsslot from displaying the slot information.
Fixes: e82fb588f573 (lsslot: replace struct options member s_name with usr_drc_name)
Signed-off-by: Chandni Verma <[email protected]>
Signed-off-by: Nathan Fontenot <[email protected]>
[tyreld: added fixes tag]
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 74715cc0e4db0e2738be7a19c852816c285d8284
Author: Nathan Fontenot <[email protected]>
Date: Mon May 22 16:40:58 2017 -0400
lsdevinfo: Add support for vNIC devices
Add support to dump information about vNIC devices so that device info
requests from the HMC can retrieve data about vNIC devices.
Signed-off-by: Nathan Fontenot <[email protected]>
[tyreld: fixed up trailing whitespace]
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 25615a80f3fb5ebcc26d7b00316afce8c46ab2f9
Author: Nathan Fontenot <[email protected]>
Date: Mon May 22 16:40:50 2017 -0400
ofpathname: Add support for vNIC devices
Add 'vnic' to the list of device types for of2l_ethernet so vNIC
devices are supported.
Signed-off-by: Nathan Fontenot <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 6464f8e96228f7db355f08f270ada1104c3562c3
Author: Amartey Pearson <[email protected]>
Date: Tue May 16 14:01:30 2017 -0500
Improve perf of drmgr/lsslot with large num of virt. dev.
The current algorithm for add_pci_vio_node walks the vdevice bus
for every theoretical DRC (1000's of times). The more vdevices
you have populated, the worse this algorithm becomes. On a system
with 450 devices, this can take over 30 seconds for example.
This modifies the algorithm to populate a node list of existing
devices (so walks the tree just once), and then uses these nodes
when populating the full list instead of walking the device tree
for each one.
NOTE: This only is changed for virtual devices - a system with
large numbers of PCI devices will not be optimized, but that is
less of a concern.
Signed-off-by: Amartey Pearson <[email protected]>
Signed-off-by: Bryant G. Ly <[email protected]>
[tyreld: changed my_drc_index type from u32 to uint32_t]
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 7539330a301ff9ac7d6fd5e1cf974bb9999100b2
Author: Tyrel Datwyler <[email protected]>
Date: Fri May 19 16:02:51 2017 -0400
Test for zlib presence at configuration time
The nvram utility links with zlib and compilation will fail if zlib.h or
libz.so are not present. Check and warn at configuration time.
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 3a7b15104fb956aa2e5debababe8536dbd4e8cef
Author: Russell Currey <[email protected]>
Date: Fri May 19 17:36:45 2017 -0400
errinjct: Remove platform check to enable KVM guests
qemu/KVM guests can have RTAS as well. There's already a check to see if
RTAS is present, there's no need to hardcode the supported platform.
Removing this check allows errinjct to work on KVM guests.
Signed-off-by: Russell Currey <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 5f70f6c1af2dd61122acfdbaa6e38be062bb220a
Author: Samuel Mendoza-Jonas <[email protected]>
Date: Fri Apr 21 16:47:57 2017 +1000
ppc64_cpu: Treat CPUs as online if cpu hotplug not enabled
cpu_online() looks for the "online" attribute to decide if a cpu is
online, however if the kernel does not have CONFIG_HOTPLUG_CPU enabled
the attribute will not exist.
If hotplug is not enabled then the cpu can be assumed to be online - in
this case, update cpu_online() to treat the cpu as online.
Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
Acked-by: Stewart Smith <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 4fcc611a09caea70e6bca6a1275211c72ac4bb45
Author: Seeteena Thoufeek <[email protected]>
Date: Wed Jan 11 15:36:33 2017 +0530
warning: command substitution: ignored null byte in input device
Ubuntu 17.04: "command substitution: ignored null byte in input" warning message is displayed while running few RAS commands.
The command execution of ls-veth, ls-vscsi, lsdevinfo, and ofpathname returns following output.
lsdevinfo
/usr/sbin/lsdevinfo: line 233: warning: command substitution: ignored null byte in input
device: name="ibmveth2"
ls-vscsi
/usr/sbin/ls-vscsi: line 72: warning: command substitution: ignored null byte in input
host0 U8286.42A.1069B3T-V8-C17-T1
ls-veth
/usr/sbin/ls-veth: line 74: warning: command substitution: ignored null byte in input
ibmveth2 U8286.42A.1069B3T-V8-C2-T1
ofpathname sda
/usr/sbin/ofpathname: line 812: warning: command substitution: ignored null byte in input
/usr/sbin/ofpathname: line 865: cd: too many arguments
/vdevice/v-scsi@30000011/disk@8100000000000000
Newer versions of bash (Bash 4.4) warn about null bytes in command substitutions. This is fixed.
Also fixed /usr/sbin/ofpathname: line 865: cd: too many arguments.
Signed-off-by: Seeteena Thoufeek <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
commit 25b8f7d67fb3acee0970cd36f24dc17fac1f6dc3
Author: Pawan K Singh5 <[email protected]>
Date: Mon Apr 10 15:00:28 2017 +0530
ofpathname : avoid duplicate entries of vFC devices
Adding support to avoid the duplicate entries of a Open Firmware device path to
logical device path for vfc-client devices.
The problem can be reproduced with the bootlist command
# bootlist -m normal /dev/sdd /dev/sds /dev/sdf /dev/sdv
# bootlist -m normal -r
/vdevice/vfc-client@30000899/disk@500507680b2255fe
/vdevice/vfc-client@30000899/disk@500507680b2255ff
/vdevice/vfc-client@3000089a/disk@500507680b2255fe
/vdevice/vfc-client@3000089a/disk@500507680b2255ff
# bootlist -m normal -o
sda---------------->expected "sdd"
sdp---------------->expected "sds"
sda---------------->expected "sdf"
sdp---------------->expected "sdv"
So, this patch check the duplicate entries of logical names of vFC devices at of2l_vfc()
and display specified bootlist :
# bootlist -m normal -r
/vdevice/vfc-client@30000899/disk@500507680b2255fe
/vdevice/vfc-client@30000899/disk@500507680b2255ff
/vdevice/vfc-client@3000089a/disk@500507680b2255fe
/vdevice/vfc-client@3000089a/disk@500507680b2255ff
# bootlist -m normal -o
sdd
sds
sdf
sdv
Signed-off-by: Pawan K Singh5 <[email protected]>
Signed-off-by: Tyrel Datwyler <[email protected]>
powerpc-utils-1.3.3
=====================================================================
commit d63e12aa7cd22d5e6c2baf595aacb644311e0217
Author: Mamatha Inamdar <[email protected]>
Date: Tue Dec 6 11:36:57 2016 -0500
nvram:read list of partion names dynamically
This patch is to read "list of partition dynamically and
use it rather than having hardcoded partition table list.
Test Results:
without patch:
nvram: ERROR: There is no Open Firmware "ibm,skiboot" partition!
with patch:
"ibm,skiboot" Partition
--------------------------
experimental-fast-reset=feeling-lucky
Signed-off-by: Mamatha Inamdar <[email protected]>
Tested-by: Vasant Hegde <[email protected]>
commit b54a095e820d0163e29b76b517b57227a358950d
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 6 11:29:17 2016 -0500
lsslot: Correct formatting fopr printing cpus and caches
Minor updates to the field sizes when printing cpus and caches
so that the fields no longer run together.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 9d363cd79315f08d00e63674b3608dd3fdd72939
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 6 11:16:14 2016 -0500
lsslot: Validate cpu->name when printing
When printing the information for all possible CPUs we can possibly print
a NULL string pointer. the libc printf code handles this gracefully by
printing '(NULL)' but this is not what we should be relying on.
This validates the cpu->name pointer before printing it and instead
prints '--' if cpu->name is not valid.
Signed-off-by: Nathan Fontenot <[email protected]>
commit b3b35e9a84913f98ab1abf8ac019c8f3a94a5e1d
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 6 11:12:06 2016 -0500
lsslot: Allow printing information of all possible cpus
The lsslot command gathers information about all possible cpus on a
system but only prints information about cpus that are present. This
patch adds the ability to print information about all possible cpus
when the '-d 4' option is used.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 8b229153221416bfdcd06ef67ad3a18fb5bea171
Author: Michel Normand <[email protected]>
Date: Tue Dec 6 11:03:00 2016 -0500
ofpathname: Avoid infinit loop in get_slave()
This is a bypass for a problem raised on openSUSE with bug
https://bugzilla.suse.com/show_bug.cgi?id=1011529
Signed-off-by: Michel Normand <[email protected]>
commit 944cc93ae316edc99bbac1a83f5b0e1aa9401657
Author: Paul A. Clarke <[email protected]>
Date: Thu Dec 1 11:05:25 2016 -0500
ppc64_cpu: emit error message for invalid core number to on- or offline
An off-by-one test is done to detect invalid core numbers for explicit
online/offline. For example, on a 16 core system, valid cores are 0-15.
However, specifying "16" has no effect, but does not produce an error:
--
# ./src/ppc64_cpu --cores-on
Number of cores online = 15
# ppc64_cpu --online-cores=16
# ppc64_cpu --online-cores=17
Invalid core to online: 17
--
This change will correctly report an error:
--
# ppc64_cpu --online-cores=16
Invalid core to online: 16
--
Signed-off-by: Paul A. Clarke <[email protected]>
commit be7583177b845b69b7c2e1f21f2652c0545c996d
Author: Nathan Fontenot <[email protected]>
Date: Tue Nov 29 11:42:37 2016 -0500
lsprop: Update and honor recurse option
The -R (recurse) option to lsprop is not honored when dumping the contents
of a directory. Update the option to also include --recurse and honor this
option when specified.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 69b62ea770c6f84f91706d8610a2815fbb19decc
Author: Nathan Fontenot <[email protected]>
Date: Tue Nov 29 11:41:27 2016 -0500
lsprop: Add command version
Signed-off-by: Nathan Fontenot <[email protected]>
commit ab587974c47f3c45929c748a16eee33e875c53f3
Author: Paul A. Clarke <[email protected]>
Date: Tue Nov 29 11:33:54 2016 -0500
ppc64_cpu: tolerate non-uniform per-core SMT mode
If not every core is in the same SMT state, the ppc64_cpu command will
report such and no information specific to the command request:
--
# ppc64_cpu --cores-on
Bad or inconsistent SMT state: use ppc64_cpu --smt=on|off to set all
cores to have the same number of online threads to continue.
Core 0: 0* 1* 2* 3*
Core 1: 4* 5* 6* 7*
Core 2: 8* 9* 10* 11*
Core 3: 12* 13* 14* 15*
Core 4: 16* 17* 18* 19*
Core 5: 20* 21* 22* 23*
Core 6: 24* 25* 26* 27*
Core 7: 28* 29* 30* 31*
Core 8: 32* 33 34 35
Core 9: 36* 37 38 39
Core 10: 40* 41* 42* 43*
Core 11: 44* 45* 46 47
Core 12: 48* 49* 50* 51*
Core 13: 52 53 54* 55*
Core 14: 56 57 58 59
Core 15: 60* 61* 62* 63
# ppc64_cpu --online-cores
Bad or inconsistent SMT state: use ppc64_cpu --smt=on|off to set all
cores to have the same number of online threads to continue.
Core 0: 0* 1* 2* 3*
Core 1: 4* 5* 6* 7*
Core 2: 8* 9* 10* 11*
Core 3: 12* 13* 14* 15*
Core 4: 16* 17* 18* 19*
Core 5: 20* 21* 22* 23*
Core 6: 24* 25* 26* 27*
Core 7: 28* 29* 30* 31*
Core 8: 32* 33 34 35
Core 9: 36* 37 38 39
Core 10: 40* 41* 42* 43*
Core 11: 44* 45* 46 47
Core 12: 48* 49* 50* 51*
Core 13: 52 53 54* 55*
Core 14: 56 57 58 59
Core 15: 60* 61* 62* 63
# ppc64_cpu --offline-cores
Bad or inconsistent SMT state: use ppc64_cpu --smt=on|off to set all
cores to have the same number of online threads to continue.
Core 0: 0* 1* 2* 3*
Core 1: 4* 5* 6* 7*
Core 2: 8* 9* 10* 11*
Core 3: 12* 13* 14* 15*
Core 4: 16* 17* 18* 19*
Core 5: 20* 21* 22* 23*
Core 6: 24* 25* 26* 27*
Core 7: 28* 29* 30* 31*
Core 8: 32* 33 34 35
Core 9: 36* 37 38 39
Core 10: 40* 41* 42* 43*
Core 11: 44* 45* 46 47
Core 12: 48* 49* 50* 51*
Core 13: 52 53 54* 55*