Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed translation of Galaxy tool with ID containing a macro #119

Open
ddeepwell opened this issue Jan 16, 2024 · 0 comments
Open

Failed translation of Galaxy tool with ID containing a macro #119

ddeepwell opened this issue Jan 16, 2024 · 0 comments

Comments

@ddeepwell
Copy link

Translation of the Galaxy tool bcftools_reheader fails with error
RuntimeError: could not find wrapper for bcftools_reheader:b7be725976b6

It appears that this is caused by the tool id containing a macro which requires parsing. The bcftools_reheader id attribute is id="bcftools_@EXECUTABLE@"

The get_xml_id function in janis_core/ingestion/galaxy/utils/galaxy.py is not general enough to handle galaxy tools with macros in the id xml attribute. This leads to the get_xml_by_id function to incorrectly return None because the query_id does not match the "bcftools_@EXECUTABLE@" string.

This can be reproduced with

from janis_core.ingestion.galaxy.gxwrappers import fetch_xml
owner = "iuc"
repo = "bcftools_reheader"
revision = "b7be725976b6"
tool_id = "bcftools_reheader"
fetch_xml(owner, repo, revision, tool_id)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant