Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gid val error #390

Closed
wants to merge 3 commits into from
Closed

Fix gid val error #390

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c39de1
fix gid val error
1daidai1 Dec 9, 2024
c22529d
fix gid val error
1daidai1 Dec 9, 2024
6121e63
fix comments
1daidai1 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions protos/PublicDefs.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ message TaskToCtld {

string excludes = 34;
string nodelist = 35;
uint32 gid = 36;
}

message TaskInEmbeddedDb {
Expand Down
1 change: 1 addition & 0 deletions src/CraneCtld/CtldGrpcServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ CtldServer::SubmitTaskToScheduler(std::unique_ptr<TaskInCtld> task) {
fmt::format("Uid {} not found on the controller node", task->uid));
}
task->SetUsername(task->password_entry->Username());
task->SetGid(task->Gid());
Nativu5 marked this conversation as resolved.
Show resolved Hide resolved

{ // Limit the lifecycle of user_scoped_ptr
auto user_scoped_ptr =
Expand Down
1 change: 1 addition & 0 deletions src/CraneCtld/CtldPublicDefs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ struct TaskInCtld {

uid = val.uid();
password_entry = std::make_unique<PasswordEntry>(uid);
gid = val.gid();
account = val.account();
name = val.name();
qos = val.qos();
Expand Down
Loading