Dev/licenses #312
Open
Dev/licenses #312
+409
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huerni
added a commit
that referenced
this pull request
Aug 16, 2024
feat: parse licenses config feat: queryLicenses feat: licenses malloc and free refactor feat: Add licenses configuration to the config template file refactor feat: Use the cqueue -L parameter to query task information for specified licenses. fix: No error is reported when the task requests non-existent licenses. merge master feat: display 'licenses' for the pending queue reason. fix: ctld restarts without allocating licenses. merge master refactor
|
merge有问题，改用rebase |
huerni
force-pushed
the
dev/licenses
branch
2 times, most recently
from
b5a1b64 to
15cd2e0
Compare
L-Xiafeng
reviewed
Oct 29, 2024
| @@ -245,7 +247,8 @@ message TaskInfo { | |||
| string username = 15; | |||
| string qos = 16; | |||
| ResourceView res_view = 17; | |||
|
|
|||
| string licenses = 18; | |||
There was a problem hiding this comment.
这里怎么不用map<string, uint32> licenses_count?
There was a problem hiding this comment.
好像是这里只在前端展示用，然后直接后端转成string了
fix: setfields fix: The task that exceeds the total number of licenses should generate an error.
Open
L-Xiafeng
reviewed
Dec 6, 2024
| @@ -245,7 +247,8 @@ message TaskInfo { | |||
| string username = 15; | |||
| string qos = 16; | |||
| ResourceView res_view = 17; | |||
|
|
|||
| string licenses = 18; | |||
|
|
||
| namespace Ctld { | ||
|
|
||
| using unorderedLicensesMap = absl::flat_hash_map<LicenseId, License>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
见前端#194