GH Actions/test: allow concurrency for build against "main" branches #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `concurrency` setting will cancel running workflows is a new push to the same branch is seen. This is useful to prevent unnecessary workflow runs (as the previous push was superseded, so the outcome is no longer relevant). However, for the "main" branches (`master` and `4.0`), this workflow cancelling means that if multiple PRs are merged in succession, only the code coverage for the _last_ merge is recorded in Coveralls as the workflow runs on `master` for the previous merges will have been cancelled. While in practice, it's not a biggie, it does make it more difficult to identify which commit/merge added or decreased code coverage. With this in mind, I'm making a small change to the `concurrency` setting for the `test` workflow only to allow those to always finish when the workflow is run for the "main" branches.
jrfnl
deleted the
feature/ghactions-dont-cancel-in-progress-main-branches
branch
|
Hmm.. at first look, this doesn't seem to be working as advertised (as in: the next PR I merged, still cancelled the builds). According to the documentation, this should be possible though and the Will have to have another look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
concurrencysetting will cancel running workflows is a new push to the same branch is seen. This is useful to prevent unnecessary workflow runs (as the previous push was superseded, so the outcome is no longer relevant).However, for the "main" branches (
masterand4.0), this workflow cancelling means that if multiple PRs are merged in succession, only the code coverage for the last merge is recorded in Coveralls as the workflow runs onmasterfor the previous merges will have been cancelled.While in practice, it's not a biggie, it does make it more difficult to identify which commit/merge added or decreased code coverage.
With this in mind, I'm making a small change to the
concurrencysetting for thetestworkflow only to allow those to always finish when the workflow is run for the "main" branches.Suggested changelog entry
N/A