Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: set up mechanism to allow for testing CBF specific code #703

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 21, 2024

Description

See the description of how this works in the CONTRIBUTING file for more information.

Includes adjustments to the GH Actions workflows to ensure the CBF specific tests are:

  • Always run for the quicktest and "normal" test runs.
  • Run for code coverage and that the code coverage reports are send in a way that they can be merged correctly.

Includes adding a "requires CS mode" condition to a few tests which would otherwise fail in CBF mode.

Suggested changelog entry

N/A

Related issues/external references

This is a preliminary PR for a series of PRs expanding the tests for the Ruleset class.

See the description of how this works in the `CONTRIBUTING` file for more information.

Includes adjustments to the GH Actions workflows to ensure the CBF specific tests are:
* Always run for the `quicktest` and "normal" test runs.
* Run for code coverage and that the code coverage reports are send in a way that they can be merged correctly.

Includes adding a "requires CS mode" condition to a few tests which would otherwise fail in CBF mode.
@jrfnl jrfnl force-pushed the feature/tests-allow-for-testing-cbf-specific-code branch from 5d24321 to bed42db Compare November 21, 2024 06:02
@jrfnl jrfnl merged commit 7aa3a24 into master Nov 22, 2024
70 checks passed
@jrfnl jrfnl deleted the feature/tests-allow-for-testing-cbf-specific-code branch November 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants