Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic/SpreadOperatorSpacingAfter: minor message readability improvement #48

Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 9, 2023

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3647:

Use space/spaces depending on the value of the $spacing property instead of using space(s) in the error message.

Original output:
image

Improved output:
image

Suggested changelog entry

  • Generic/SpreadOperatorSpacingAfter: minor message readability improvement

…ment

Use `space`/`spaces` depending on the value of the `$spacing` property instead of using `space(s)` in the error message.
@jrfnl jrfnl force-pushed the feature/generic-spreadoperatorspacing-after-msg-improvement branch from ea36dbe to 511b877 Compare December 4, 2023 15:00
@jrfnl jrfnl merged commit b0cb9c5 into master Dec 4, 2023
65 checks passed
@jrfnl jrfnl deleted the feature/generic-spreadoperatorspacing-after-msg-improvement branch December 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant