PHP 8.2 | Squiz/VariableComment: allow for stand-alone null/true/false types and more #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e types Since PHP 8.2, stand-alone use of `true`, `false` and `null` is allowed. However, if these were used as the type for a property, the docblock would not be found. Fixed now. Includes unit tests.
There were some more allowed types missing from the list of tokens to skip over to find a docblock. Fixed now. Includes unit tests.
jrfnl
force-pushed
the
feature/squiz-variablecomment-allow-for-more-missing-types
branch
from
60c95d8 to
b04f0a6
Compare
jrfnl
deleted the
feature/squiz-variablecomment-allow-for-more-missing-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.2 | Squiz/VariableComment: allow for stand-alone null/true/false types
Since PHP 8.2, stand-alone use of
true,falseandnullis allowed.However, if these were used as the type for a property, the docblock would not be found.
Fixed now.
Includes unit tests.
Squiz/VariableComment: allow for various other missing types
There were some more allowed types missing from the list of tokens to skip over to find a docblock.
Fixed now.
Includes unit tests.
Suggested changelog entry
true/false/nulltype declarationsparent,selfor a namespace relative class name type declarationRelated issues/external references
Related to #178 and #209
Types of changes