Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting user-agent when downloading #54

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix setting user-agent when downloading #54

merged 3 commits into from
Sep 12, 2023

Conversation

nebfield
Copy link
Member

  • Move user-agent setup to config
    • Removed setting user-agent with a public parameter and just read from config
  • Also I forgot to set headers when downloading files 🤭

@nebfield
Copy link
Member Author

closes PGScatalog/pgsc_calc#165

ens-lgil
ens-lgil approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ens-lgil ens-lgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

pgscatalog_utils/download/Catalog.py Outdated Show resolved Hide resolved
@nebfield nebfield merged commit 6ca8bcc into dev Sep 12, 2023
1 check passed
@nebfield nebfield deleted the fix-user-agent branch September 12, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ens-lgil ens-lgil ens-lgil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebfield @ens-lgil