Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem variants? #23

Open
smlmbrt opened this issue Aug 3, 2023 · 6 comments
Open

Problem variants? #23

smlmbrt opened this issue Aug 3, 2023 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@smlmbrt
Copy link
Member

smlmbrt commented Aug 3, 2023

Some reports:

variants with a valid rsid tags but an "Unknown" source reference tag or “NR” genome_build tag, though it also occurs in some novel variants. For example PGS003753_hmPOS_GRCh38.txt.gz rs147937400 (T>C), which seems to correspond to an original reference of GRCh37 (chr6 29068745), but appears unmapped in the PGS Catalog’s GRCh38 harmonized score file (UCSC reports it mapped to chr6 29100968 in GRCh38)

Related to PGScatalog/pgsc_calc#137

@smlmbrt smlmbrt added the help wanted Extra attention is needed label Aug 3, 2023
@smlmbrt
Copy link
Member Author

smlmbrt commented Aug 31, 2023

@ens-lgil can we look at which it seems to miss that rsID? It seems 104/35445 don't map and get "Unknown" but at least rs147937400 should be mapped to chr6 via ensembl: https://www.ensembl.org/Homo_sapiens/Variation/Explore?db=core;r=6:29100468-29101468;v=rs147937400;vdb=variation;vf=193308664

@ens-lgil
Copy link
Member

Yes, it seems that it's an issue with the UCSC liftover. We need to find an other mapping source when this happens.

@smlmbrt
Copy link
Member Author

smlmbrt commented Aug 31, 2023

But that one should have been mapped by the rsID to chr6, not the liftover.

@ens-lgil
Copy link
Member

ens-lgil commented Sep 4, 2023

This PR should fix at least partially the issue: PGScatalog/pgs_variants_coords#4

@smlmbrt
Copy link
Member Author

smlmbrt commented Sep 5, 2023

Will it require re-running everything?

@ens-lgil
Copy link
Member

ens-lgil commented Sep 5, 2023

Yes, just to be on the safe side. Or at least each Harmonized files with "Unknown" source + rsID column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants