From 7fc4b9ca3d3b134a15e6869173ac5cf6e83cca36 Mon Sep 17 00:00:00 2001 From: Dilan Pathirana <59329744+dilpath@users.noreply.github.com> Date: Mon, 18 Nov 2024 23:25:31 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daniel Weindl --- petab_select/plot.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/petab_select/plot.py b/petab_select/plot.py index 2642de4..08137c8 100644 --- a/petab_select/plot.py +++ b/petab_select/plot.py @@ -109,7 +109,7 @@ def upset( The criterion. Returns: - The plot axes (see documentation from the `upsetplot` package). + The plot axes (see documentation from the `upsetplot `__ package). """ # Get delta criterion values values = np.array( @@ -318,7 +318,7 @@ def graph_history( if label_diff := set(colors).difference(list(G)): raise ValueError( "Colors were provided for the following model labels, but " - "these are not in the graph: {label_diff}" + f"these are not in the graph: {label_diff}" ) node_colors = [ @@ -395,7 +395,7 @@ def bar_criterion_vs_models( if label_diff := set(colors).difference(criterion_values): raise ValueError( "Colors were provided for the following model labels, but " - "these are not in the graph: {label_diff}" + f"these are not in the graph: {label_diff}" ) bar_kwargs["color"] = [ @@ -467,7 +467,7 @@ def scatter_criterion_vs_n_estimated( if label_diff := set(colors).difference(labels.values()): raise ValueError( "Colors were provided for the following model labels, but " - "these are not in the graph: {label_diff}" + f"these are not in the graph: {label_diff}" ) scatter_kwargs["c"] = [ colors.get(model_label, NORMAL_NODE_COLOR)