-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
387 clean reset of applet state when scan is overwritten #395
base: master
Are you sure you want to change the base?
387 clean reset of applet state when scan is overwritten #395
Conversation
Alternatively to e6fef59, we could only reset the applet |
I wonder whether this is enough. Ideally, we'd want to clear out all of |
It cleared it with a I added two commits that both individually should solve the problem (pick one?) |
What happens if one scan with an explicit prefix is scheduled on top of a second scan with the same explicit prefix? This is something we quite possibly can't handle cleanly, but maybe the solutions differ there. In general, this is some tricky order-dependent code, so we should doucment the constraints assumed by the solution somewhere, at least in the form of some unit tests (like for the single-point |
The second scan runs from a clean applet/dataset state with correct RID and correct data. |
We could, however, catch that in def run(self):
"""Run the (possibly trivial) scan."""
previous_completed = self.get_dataset(self.dataset_prefix + "completed", default=True)
if not previous_completed:
raise Exception("TopLevelRunner with same explicit prefix is still running") Scans usually have a new dataset where |
When the
source_id
changes, just reset the applet state.