You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
Based on the fix of MC-101001 you can now hook item entities and reel them in. The problem is that PGMListener.nerfFishing(PlayerFishEvent) converts any item entity even if it is hooked and not catched and therefore existed in the world before. This allows for example to "destroy" wool in the enemy's wool room.
However, to make sure a team cannot reel in the enemies wool maybe add a listener for a ProjectileHitEvent and then either prevent pulling items completely or prevent it for certain items like wool.
How to reproduce
This can be currently seen on play.stratus.network (but not on the mapdev server) since the treasure fishing loot is disabled there.
Get a fishing rod (this is for example possible in "Persisto")
Throw an item on the ground
Cast the fishing rod at the item
Try to reel in the item
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The bug
Based on the fix of MC-101001 you can now hook item entities and reel them in. The problem is that
PGMListener.nerfFishing(PlayerFishEvent)
converts any item entity even if it is hooked and not catched and therefore existed in the world before. This allows for example to "destroy" wool in the enemy's wool room.The method should probably only convert the item if the state is
PlayerFishEvent.State.CAUGHT_FISH
.However, to make sure a team cannot reel in the enemies wool maybe add a listener for a
ProjectileHitEvent
and then either prevent pulling items completely or prevent it for certain items like wool.How to reproduce
This can be currently seen on
play.stratus.network
(but not on the mapdev server) since the treasure fishing loot is disabled there.The text was updated successfully, but these errors were encountered: