Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blitz/12v12v12v12] CannonQuest #864

Open
7 tasks done
ThatApplePieGuy opened this issue Jan 17, 2024 · 3 comments
Open
7 tasks done

[Blitz/12v12v12v12] CannonQuest #864

ThatApplePieGuy opened this issue Jan 17, 2024 · 3 comments
Labels
arcade This submission is for an arcade map loaded The map has been loaded onto Overcast Community map This issue is related to a map in the repository submission This map is being submitted to Overcast Community

Comments

@ThatApplePieGuy
Copy link
Contributor

ThatApplePieGuy commented Jan 17, 2024

Checklist

  • I have pruned the map. (If you used OCC Mapmaker and downloaded your map, it has been pruned for you.)
  • I have agreed with assigning the CC BY-SA license to this map, as mentioned in the README.
  • I have read and understood the map submission guidelines.
  • I have created an XML file.
  • I have created a map image.
  • I have uploaded the map zip file to a file sharing service.
  • The map has been tested locally to make sure it works.

Map Name

CannonQuest

Gamemode & Map Description

4-team blitz with a cannoning kit and randomly generated islands. Players can bridge to mid after 5 minutes and a world border starts shrinking after 10.

Team Sizes

12v12v12v12

Screenshots

https://imgur.com/a/9PZwHra

XML

https://gist.github.com/ThatApplePieGuy/b445a5ab4e89f309bf4c6fe0bb87af10

Map Image

map

Map Download

cannonquest.zip
cannonquest.zip (old)

@ThatApplePieGuy ThatApplePieGuy added map This issue is related to a map in the repository submission This map is being submitted to Overcast Community labels Jan 17, 2024
@mitchts
Copy link
Member

mitchts commented Jan 17, 2024

This is purely just a comment on the XML at first glace.

https://gist.github.com/ThatApplePieGuy/b445a5ab4e89f309bf4c6fe0bb87af10#file-map-xml-L130-L147

This can be simplified as

<filters>
    <match-started id="match-started"/>
    <after id="after-15s" duration="15s" message="Cages open in {0}" filter="match-started"/>
    <time id="after-5m">5m</time> <!-- then use 'not(after-5m)' in place of your old not-5m filter -->
    <time id="after-14m">14m</time>
    <after id="end-game" duration="1m" message="The game will end in {0}" filter="after-14m"/>
</filters>

All your structure dynamics can be simplified as:

<dynamic id="place9" structure="2v" location="13,4,13" filter="aqua_layout=0" trigger="match-started"/>

All those clear-spawners dynamics seem obscene. Are they truely necessary? Could you instead use a set action filtered to the playable area and mob spawner blocks to set them to air that way, assuming that is what they are doing..? E.g.:

<regions>
    <rectangle id="playable-area" min="-56,-56" max="57,57"/> <!-- your playable area -->
</regions>
<filters>
    <material id="monster-spawners">mob spawner</material>
</filters>
<actions>
    <trigger scope="match" filter="match-started-or-with-some-delay">
        <action>
            <fill region="playable-area" filter="monster-spawners" material="air"/>
        </action>
    </trigger>
</actions>

From the screenshots provided, one team can get absoutely shafted with not so great islands giving almost nowhere to cannon. Is this deliberate or a side-effect of the way the structures have been handled?

@ThatApplePieGuy
Copy link
Contributor Author

Thanks, I implemented the cleanup and regenerated all the structures so each layout must have a minimum number of flat tiles

All those clear-spawners dynamics seem obscene. Are they truely necessary? Could you instead use a set action filtered to the playable area and mob spawner blocks to set them to air that way, assuming that is what they are doing..? E.g.:

<regions>
    <rectangle id="playable-area" min="-56,-56" max="57,57"/> <!-- your playable area -->
</regions>
<filters>
    <material id="monster-spawners">mob spawner</material>
</filters>
<actions>
    <trigger scope="match" filter="match-started-or-with-some-delay">
        <action>
            <fill region="playable-area" filter="monster-spawners" material="air"/>
        </action>
    </trigger>
</actions>

This wouldn't work because we don't want to clear every spawner, only the ones that aren't needed for the layout that gets chosen. In the screenshots you can see certain islands types have spawners in their center

@calcastor calcastor added loaded The map has been loaded onto Overcast Community arcade This submission is for an arcade map labels Jan 22, 2024
@calcastor
Copy link
Member

Loaded in b445683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcade This submission is for an arcade map loaded The map has been loaded onto Overcast Community map This issue is related to a map in the repository submission This map is being submitted to Overcast Community
Projects
None yet
Development

No branches or pull requests

3 participants