Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using node_modules instead of bower #34

Open
mqueirozcorreia opened this issue Jan 19, 2019 · 3 comments
Open

Using node_modules instead of bower #34

mqueirozcorreia opened this issue Jan 19, 2019 · 3 comments

Comments

@mqueirozcorreia
Copy link

Since bower is recommends in his page migrating to " Yarn and Webpack or Parcel". You guys are looking forward to update the code to not try to find the bower_components folders anymore? Do you want any help on that?

@OverZealous
Copy link
Owner

Why would I remove the old functionality? It already checks for node_modules at the same time, so there's no reason to not search for old bower configs.

@mqueirozcorreia
Copy link
Author

mqueirozcorreia commented Jan 20, 2019

That is true, after looking after code node_module is used!

I was in doubt because of the error message below

Unable to load version from bower.json

			if(!packageInfo.version) {
				throw new Error('Unable to load version from bower.json for package "' + pkg + '".  Looked at:\n    "' + packageFiles.join('",\n    "') + '"');
			}

Do you want any help improving the error message?

@OverZealous
Copy link
Owner

I'm not sure I care that much, though in theory we could try to look up the node_modules package for the file as well. The only reason you'd see that error is if you provided package in your config, which the manual explains here:

By providing the package name, cdnizer will look up the version string of the currently installed Bower package […]

I'm not interested in spending much time maintaining this library right now, but I'll re-open this task as something to look into in the future when I get more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants