Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitewide style updates #25

Open
chrisdecrypted opened this issue Feb 18, 2022 · 0 comments
Open

Sitewide style updates #25

chrisdecrypted opened this issue Feb 18, 2022 · 0 comments

Comments

@chrisdecrypted
Copy link
Contributor

I'm creating this issue for a PR I've already completed.

The site previously used a naming convention with the prefix: tPallette. I have removed/replaced these values from the tailwind config to match DaisyUI naming, the main css file was also updated and all references were updated in .html and .md files.

I also removed a couple margin bottom utilities that were added to @apply's in the main css file. It's my opinion that these refinements should be scoped more locally instead of applied to every h1, h3, etc. tag. I think this will make it easier for contributors who may not understand how the element is being styled.
chrisdecrypted added a commit to chrisdecrypted/odevs-eleventy-starter that referenced this issue Feb 18, 2022
@chrisdecrypted
fix: Site-wide style updates OrlandoDevs#25
f7c2d1c 
- Mass replace tPallete* to DaisyUI equivalents
- Remove tPallette colors from twconfig
- Remove mb-* values from apply to avoid confusion for contributors
snohio pushed a commit that referenced this issue Oct 21, 2024
@lastlink
Merge pull request #25 from snohio/lastlink/tests
bb32713 
mock geo api and fix jest deprecations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisdecrypted