Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Guidelines page accessibility issues #554

Closed
10 tasks done
pya35 opened this issue Dec 19, 2023 · 6 comments
Closed
10 tasks done

[Bug]: Guidelines page accessibility issues #554

pya35 opened this issue Dec 19, 2023 · 6 comments

Comments

@pya35
Copy link
Member

pya35 commented Dec 19, 2023

Prerequisites

Your test device

iPhone 14 Plus

OS Version

17.1.1

App version

v0.16.0

Describe the issue

This list is about the defaut page displayed in app : "Guidelines"

override open func accessibilityElementDidBecomeFocused() {
        backgroundColor = .focused
    }
  • voice over grouping: when user changes the colour theme, the description of the warning popup is vocalized with title only.
    Recommandation: Group popup title and description so the user has the whole information at once.

  • landscape mode : landscape mode from guidelines page leads to open typography automatically
    **Recommandation: no content change on landscape mode

  • tap cancellation not possible on colour palette icon. User should be able to cancel the tap by moving the finger out of the button
    Recommandation : Don't activate button on down action

  • No vocalization of title after displaying the page #683
    Recommandation: Use announcements (notifications) to force the title page vocalization - To be done on each main page Guidelines, Components, Modules & About

Expected Behavior

Page 100% accessible (updated status 19/12/2023: 71%)

@pya35 pya35 added 🐞 bug Something isn't working 🔍 triage A new issue that needs to be treated labels Dec 19, 2023
@ludovic35
Copy link
Member

ludovic35 commented Dec 20, 2023

To avoid vocalization of text in image do:
group bouton + image via accessibilityElement(children: .contain)

@ludovic35
Copy link
Member

it does not work, need more investigation

@pya35
Copy link
Member Author

pya35 commented Jan 23, 2024

landscape mode : landscape mode from guidelines page leads to open typography automatically seems to be fixed on last release

@pya35
Copy link
Member Author

pya35 commented Jan 26, 2024

keyboard focus visibility can be solved with high contrast in Full Keyboard Access settings, no fix needed

@pylapp
Copy link
Member

pylapp commented Jan 31, 2024

@pya35 About your comment "information transmitted only by color : selected tab differs only by orange colour.", it is the native iOS behavior.
Did you look on some a11Y settings in the device to get workarounds?

About the case where "image vocalization "typography" -> with VoiceOver we hear "75 Aa 55Aa", not useful.", it is already fixed since at least commit c2f245c in qualif

Same thing for "image vocalization "spacing" -> with VoiceOver we hear "plus plus", not useful." case.

In case "voice over grouping: when user changes the colour theme, the description of the warning popup is vocalized with title only.", what did you mean @pya35? Today vocalization of menu vocalizes the texts of the menu items, is it enough?

About the case "No vocalization of title after displaying the page", is it managed in issue #588

@pylapp
Copy link
Member

pylapp commented Jan 31, 2024

@pya35 I understand the needs behind your case "tap cancellation not possible on colour palette icon. User should be able to cancel the tap by moving the finger out of the button", however it is the native behaviour of iOS for such pickers: the content is displayed when the component is pressed, it's slightly different than buttons for example.

@pylapp pylapp removed the 🔍 triage A new issue that needs to be treated label Jan 31, 2024
@B3nz01d B3nz01d assigned pya35 and unassigned pya35 Feb 7, 2024
@pya35 pya35 self-assigned this Feb 21, 2024
@pya35 pya35 removed their assignment Feb 29, 2024
@pya35 pya35 closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

No branches or pull requests

3 participants