From 8493377a969216e74d49bf188c172284117c7817 Mon Sep 17 00:00:00 2001 From: Tayeb Sedraia Date: Mon, 27 May 2024 16:52:59 +0200 Subject: [PATCH] [P1] bug a11y module about title header (#828) * app : add accessibility header * add changelog issues --- CHANGELOG.md | 2 ++ .../Components/Chips/Pickers/ODSFilterChipPicker.swift | 1 + .../Screens/Modules/About/AboutModule.swift | 1 + 3 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13c96dd0..c7338d36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [DemoApp] A11y - Target size is too small for info and chevron components, difficult to tap without mistake. ([#732](https://github.com/Orange-OpenSource/ods-ios/issues/732)) - [DemoApp] A11y - Buttons component : group labels and buttons ([#760](https://github.com/Orange-OpenSource/ods-ios/issues/760)) - [DemoApp] A11y - Title is the same for both variants "Progress bar demo", title must be unique. ([#724](https://github.com/Orange-OpenSource/ods-ios/issues/724)) +- [DemoApp] A11y - Buttons component : group labels and buttons ([#760](https://github.com/Orange-OpenSource/ods-ios/issues/760)) +- [DemoApp/SDK] A11y - Module - About : Title header ([#827](https://github.com/Orange-OpenSource/ods-ios/issues/727)) ## [1.1.0](https://github.com/Orange-OpenSource/ods-ios/compare/1.0.0...1.1.0) - 2024-03-08 diff --git a/OrangeDesignSystem/Sources/OrangeDesignSystem/Components/Chips/Pickers/ODSFilterChipPicker.swift b/OrangeDesignSystem/Sources/OrangeDesignSystem/Components/Chips/Pickers/ODSFilterChipPicker.swift index 465d746d..547ccd09 100644 --- a/OrangeDesignSystem/Sources/OrangeDesignSystem/Components/Chips/Pickers/ODSFilterChipPicker.swift +++ b/OrangeDesignSystem/Sources/OrangeDesignSystem/Components/Chips/Pickers/ODSFilterChipPicker.swift @@ -53,6 +53,7 @@ public struct ODSFilterChipPicker: View where Value: Hashable { VStack(alignment: .leading, spacing: ODSSpacing.s) { title? .odsFont(.headlineS) + .accessibilityAddTraits(.isHeader) .frame(maxWidth: .infinity, alignment: .leading) .padding(.horizontal, ODSSpacing.m) diff --git a/OrangeDesignSystemDemo/OrangeDesignSystemDemo/Screens/Modules/About/AboutModule.swift b/OrangeDesignSystemDemo/OrangeDesignSystemDemo/Screens/Modules/About/AboutModule.swift index 85d9a7b9..049078ae 100644 --- a/OrangeDesignSystemDemo/OrangeDesignSystemDemo/Screens/Modules/About/AboutModule.swift +++ b/OrangeDesignSystemDemo/OrangeDesignSystemDemo/Screens/Modules/About/AboutModule.swift @@ -63,6 +63,7 @@ struct AboutSetup: View { .odsFont(.headlineS) .padding(.top, ODSSpacing.m) .padding(.bottom, ODSSpacing.s) + .accessibilityAddTraits(.isHeader) Text("screens.modules.about.mandatory")