Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Exposed Dropdown Menu backgound changed to 'surface' in 0.15 #634

Closed
1 task done
LaurentRenard opened this issue Sep 18, 2023 · 2 comments · Fixed by #640
Closed
1 task done

[Bug]: Exposed Dropdown Menu backgound changed to 'surface' in 0.15 #634

LaurentRenard opened this issue Sep 18, 2023 · 2 comments · Fixed by #640
Labels
🐞 bug Something isn't working 👌 OK PO v1.0

Comments

@LaurentRenard
Copy link

Prerequisites

Your test device

Pixel 3 XL

OS Version

Android 12

App version

0.15

Describe the issue

Since release 0.15, when in dark mode, an Exposed Dropdown Menu appears with a surface background, what does not look nice when used in a composable with a standard background :

ExposedDropdownMenu

Expected Behavior

Exposed Dropdown Menu should be rendered with inherited background, similarly to the documentation
@LaurentRenard LaurentRenard added 🐞 bug Something isn't working 🔍 triage A new issue that needs to be treated labels Sep 18, 2023
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Sep 19, 2023
florentmaitre added a commit that referenced this issue Sep 22, 2023
@florentmaitre
[#634] Fix background color of components in dark mode
7d4e3d9
@florentmaitre florentmaitre linked a pull request Sep 22, 2023 that will close this issue
634 - [Bug]: Exposed Dropdown Menu backgound changed to 'surface' in 0.15 #640
Merged
@paulinea paulinea assigned B3nz01d and unassigned florentmaitre Sep 25, 2023
@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 4, 2023

@paulinea can this be tested in the demo app?

@paulinea
Copy link
Member

paulinea commented Oct 5, 2023

@B3nz01d Yes but you have to compare with the previous version

@paulinea paulinea added the v1.0 label Oct 17, 2023
@B3nz01d B3nz01d removed their assignment Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 👌 OK PO v1.0
Projects
None yet
Milestone
No milestone
4 participants
@florentmaitre @LaurentRenard @paulinea @B3nz01d