Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Spinners #2290

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Oct 9, 2023

New Sass vars:

  • $spinner-color

⚠️ Added temporary data-bs-theme="dark" for buttons containing spinners. This should go if we modify color: automatically with [data-bs-theme].

Live previews

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 09cec75
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6524f42efa64a30008903cbb
😎 Deploy Preview https://deploy-preview-2290--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review October 9, 2023 12:25
@julien-deramond julien-deramond changed the title Dark mode: spinners Dark mode: Spinners Oct 9, 2023
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we should recheck this once we merge text utilities since the orange used here is #f16e00 everywhere.
There's an issue here, do you think we should care about this right know ?

@julien-deramond
Copy link
Contributor Author

julien-deramond commented Oct 9, 2023

I can add a sub-task to re-check that for text utilities and buttons yes. Right now, there's nothing else I can do without breaking other stuff.

Edit: I'll add a sub-task to re-check that for text utilities and a sub-task to remove data-bs-theme="dark" from spinners used alongside buttons if/when we decide to force the color: for [data-bs-theme] (it would be automatically modified).

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes, the actual solution for spinners inside buttons might only work for light theme documentation once buttons will be handled but let's try it this way and document to recheck once finished.

@julien-deramond julien-deramond merged commit 2e73d1a into main-jd-dark-mode Oct 10, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-jd-dark-mode-spinners branch October 10, 2023 06:58
@julien-deramond julien-deramond mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants