-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Spinners #2290
Dark mode: Spinners #2290
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we should recheck this once we merge text utilities since the orange used here is #f16e00
everywhere.
There's an issue here, do you think we should care about this right know ?
Edit: I'll add a sub-task to re-check that for text utilities and a sub-task to remove |
8716f66
to
09cec75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the changes, the actual solution for spinners inside buttons might only work for light theme documentation once buttons will be handled but let's try it this way and document to recheck once finished.
New Sass vars:
$spinner-color
data-bs-theme="dark"
for buttons containing spinners. This should go if we modifycolor:
automatically with[data-bs-theme]
.Live previews