Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Checkboxes and radios #2281

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 4, 2023

Description

Form checks in dark mode, by using existing and new Sass vars :

Sass var Previous value New value
$form-check-input-disabled-color $gray-900 var(--#{$prefix}gray-tweak)
$form-check-input-disabled-filter - var(--#{$prefix}input-filter)

⚠️ New CSS vars:

CSS var Light mode value Dark mode value
--bs-gray-tweak #333333 #666666
--bs-input-filter $invert-filter none

⚠️ --bs-input-filter introduced instead of using @include color-mode(dark) from Bootstrap since this looks a bit buggy atm, especially when nesting light mode inside global dark.

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5e6e2a8
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6527ed20ecb9b1000826be23
😎 Deploy Preview https://deploy-preview-2281--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review October 5, 2023 14:05
@julien-deramond julien-deramond force-pushed the main-lmp-checks-radios-dark branch from 49bd416 to 1286d56 Compare October 10, 2023 06:10
@julien-deramond
Copy link
Contributor

julien-deramond commented Oct 10, 2023

  • Rebased the branch onto main-jd-dark-mode
  • Added --bs-gray-tweak and --bs-input-filter to the table in /dark-mode page
  • Reintroduced a part of the removed "Boosted mod" comment (it must stay but without saying that it's not implemented in Boosted)

@julien-deramond julien-deramond merged commit 0e9a3e1 into main-jd-dark-mode Oct 12, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-lmp-checks-radios-dark branch October 12, 2023 13:01
@julien-deramond julien-deramond mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants